Re-land Catch up the spec update in CSS Rhythmic Sizing

Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not on the 2nd build in a row.

BUG=586413
Review-Url: https://codereview.chromium.org/2736043002
Cr-Commit-Position: refs/heads/master@{#455337}
Committed: https://chromium.googlesource.com/chromium/src/+/33bf66decbb5933a985bae31a2fa01e9fb46298f

[kojii, 2017-03-07 17:37:52]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 17:39:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-07 17:50:00]

Description was changed from

==========
Catch up the spec update in CSS Rhythmic Sizing

This patch catches up spec changes in CSS Rhythmic Sizing[1]. In
particular:
1. The property name was changed to 'line-height-step'.
2. The value syntax was changed to single <length>.
3. The baseline position feature was removed.

Tests in csswg-test were updated[2] and imported to fail. All of them
pass in this patch.

The feature is still behind the flag.

[1] https://drafts.csswg.org/css-rhythm/
[2]
https://github.com/w3c/csswg-test/commit/50a861a451a1fe9cc80044568c2572127297...

BUG=586413

Review-Url: https://codereview.chromium.org/2704343003
Cr-Commit-Position: refs/heads/master@{#455008}
Committed:
https://chromium.googlesource.com/chromium/src/+/2344921f94b85be9884ed847d9a0...

patch from issue 2704343003 at patchset 120001
(http://crrev.com/2704343003#ps120001)
==========

to

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008.

The failed build[1] log says:
gen/blink/core/css/properties/CSSPropertyAPISnapHeight.h doesn't exist
gen/blink/core/css/properties/CSSPropertyDescriptor.cpp is dirty
and bunch of files in the directory are dirty, but it can't reproduce in
local linux x64 nor on try-bots.

[1] https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34558
==========

[kojii, 2017-03-07 17:50:17]

Description was changed from

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008.

The failed build[1] log says:
gen/blink/core/css/properties/CSSPropertyAPISnapHeight.h doesn't exist
gen/blink/core/css/properties/CSSPropertyDescriptor.cpp is dirty
and bunch of files in the directory are dirty, but it can't reproduce in
local linux x64 nor on try-bots.

[1] https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34558
==========

to

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008.

The failed build[1] log says:
gen/blink/core/css/properties/CSSPropertyAPISnapHeight.h doesn't exist
gen/blink/core/css/properties/CSSPropertyDescriptor.cpp is dirty
and bunch of files in the directory are dirty, but it can't reproduce in
local linux x64 nor on try-bots.

[1] https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34558

BUG=586413
==========

[kojii, 2017-03-07 17:50:49]

The CQ bit was unchecked by kojii@chromium.org

[kojii, 2017-03-07 17:59:28]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 18:01:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-07 18:06:19]

Description was changed from

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008.

The failed build[1] log says:
gen/blink/core/css/properties/CSSPropertyAPISnapHeight.h doesn't exist
gen/blink/core/css/properties/CSSPropertyDescriptor.cpp is dirty
and bunch of files in the directory are dirty, but it can't reproduce in
local linux x64 nor on try-bots.

[1] https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/34558

BUG=586413
==========

to

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not.

BUG=586413
==========

[kojii, 2017-03-07 18:09:38]

Description was changed from

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not.

BUG=586413
==========

to

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not on 2nd build in a row.

BUG=586413
==========

[kojii, 2017-03-07 18:09:56]

Description was changed from

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not on 2nd build in a row.

BUG=586413
==========

to

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not on the 2nd build in a row.

BUG=586413
==========

[commit-bot: I haz the power, 2017-03-07 20:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 20:35:03]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-03-08 00:54:48]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-03-08 00:54:48]

PTAL.

[eae, 2017-03-08 01:10:38]

LGTM

[kojii, 2017-03-08 01:32:51]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:34:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 01:54:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488936771987430,
"parent_rev": "3164ef05aedfd208cf1d9e43558d7e8d59b14a2c", "commit_rev":
"33bf66decbb5933a985bae31a2fa01e9fb46298f"}

[commit-bot: I haz the power, 2017-03-08 01:55:14]

Description was changed from

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not on the 2nd build in a row.

BUG=586413
==========

to

==========
Re-land Catch up the spec update in CSS Rhythmic Sizing

This reverts r455020 and re-lands r455008 with a fix in core/BUILD.gn.

When files in core/css/properties are renamed, core/BUILD.gn needed to
be changed in addition to core/css/BUILD.gn, or the "compile confirm
no-op" step fails.

This can be confirmed locally by whether ninja prints
  ninja: no work to do.
line or not on the 2nd build in a row.

BUG=586413

Review-Url: https://codereview.chromium.org/2736043002
Cr-Commit-Position: refs/heads/master@{#455337}
Committed:
https://chromium.googlesource.com/chromium/src/+/33bf66decbb5933a985bae31a2fa...
==========

[commit-bot: I haz the power, 2017-03-08 01:55:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33bf66decbb5933a985bae31a2fa...