third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 2736043002: Re-land Catch up the spec update in CSS Rhythmic Sizing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2736043002: Re-land Catch up the spec update in CSS Rhythmic Sizing (Closed)

Patch Set: Fix core/BUILD.gn Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index ad198f684af4f2403f66bfea1c444ea193bfde7a..d84cc51d31acef5532c79d7ba352ad6c673c4049 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -774,10 +774,8 @@ bool ComputedStyle::diffNeedsFullLayoutAndPaintInvalidation(

other.m_rareInheritedData->m_textSizeAdjust ||

m_rareInheritedData->listStyleImage !=

other.m_rareInheritedData->listStyleImage ||

- m_rareInheritedData->m_snapHeightUnit !=

- other.m_rareInheritedData->m_snapHeightUnit ||

- m_rareInheritedData->m_snapHeightPosition !=

- other.m_rareInheritedData->m_snapHeightPosition ||

+ m_rareInheritedData->m_lineHeightStep !=

+ other.m_rareInheritedData->m_lineHeightStep ||

m_rareInheritedData->textStrokeWidth !=

other.m_rareInheritedData->textStrokeWidth)

return true;