cc: Clarify that color spaces are for raster

cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

R=enne
TBR=esprehn (content/)
BUG=687357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2735943002
Cr-Commit-Position: refs/heads/master@{#455517}
Committed: https://chromium.googlesource.com/chromium/src/+/2c6d2707d8ea850c862f04ac066724273981e88f

[ccameron, 2017-03-07 02:36:09]

Description was changed from

==========
cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

BUG=687357
==========

to

==========
cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

BUG=687357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-03-07 02:36:34]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2017-03-07 02:37:11]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-03-07 02:37:12]

This renaming clears up some of the confusion in
https://codereview.chromium.org/2728173004/

[commit-bot: I haz the power, 2017-03-07 02:37:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 02:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 02:49:19]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[enne (OOO), 2017-03-07 17:24:49]

Oooooooooh.  Thank you!  This helps a lot.

lgtm

[ccameron, 2017-03-08 02:52:47]

Description was changed from

==========
cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

BUG=687357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

R=enne
TBR=esprehn (content/)
BUG=687357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-03-08 02:54:50]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-08 02:54:50]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2735943002/#ps20001
(title: "Rebase (a few times)")

[commit-bot: I haz the power, 2017-03-08 02:55:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:18:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:18:52]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[ccameron, 2017-03-08 03:20:33]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:20:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:00:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:00:10]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[ccameron, 2017-03-08 06:19:47]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:20:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 06:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:40:34]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[ccameron, 2017-03-08 19:03:39]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-08 19:04:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 19:42:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488999819436510,
"parent_rev": "37fc2c0e956c32dda663bc7c3e93bdf16779b35d", "commit_rev":
"2c6d2707d8ea850c862f04ac066724273981e88f"}

[commit-bot: I haz the power, 2017-03-08 19:43:32]

Description was changed from

==========
cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

R=enne
TBR=esprehn (content/)
BUG=687357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Clarify that color spaces are for raster

The color spaces that are sent to cc::LayerTree and friends are to be
used for rasterization. They happen to be based on the display's color
space, but that just confuses things.

Also, LayerTreeSettings::color_correct_rendering really only has to do
with rasterization, so, rename it to color_correct_rasterization.

R=enne
TBR=esprehn (content/)
BUG=687357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2735943002
Cr-Commit-Position: refs/heads/master@{#455517}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c6d2707d8ea850c862f04ac0667...
==========

[commit-bot: I haz the power, 2017-03-08 19:43:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2c6d2707d8ea850c862f04ac0667...