Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2735933002: DevTools: add tests to fixate bindings behavior (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add tests to fixate bindings behavior This patch adds a bunch of tests to fixate bindings behavior: - bindings-* tests ensure that workspace is populated correctly - navigator-* tests ensure that navigator is populated correctly The binding-* and navigator-* tests are very similar, but since navigator might rely less on workspace in future, they're kept separate. These tests will help to evaluate changes which will happen to bindings and navigator during bindings refactoring. BUG=670180 R=dgozman Review-Url: https://codereview.chromium.org/2735933002 Cr-Commit-Position: refs/heads/master@{#455531} Committed: https://chromium.googlesource.com/chromium/src/+/f4fbdf6154d37fcb940bfd37b15b2c2bb0e5ada0

Patch Set 1 #

Patch Set 2 : moar tests #

Patch Set 3 : markstep #

Patch Set 4 : nit #

Patch Set 5 : DevTools: add tests to fixate bindings behavior #

Unified diffs Side-by-side diffs Delta from patch set Stats (+752 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-attach-detach.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-attach-detach-expected.txt View 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-navigate.html View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-frame-navigate-expected.txt View 1 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-main-frame-navigated.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-main-frame-navigated-expected.txt View 1 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-multiple-frames.html View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-multiple-frames-expected.txt View 1 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js View 1 2 3 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-frame-attach-detach.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-frame-attach-detach-expected.txt View 1 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-frame-navigate.html View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-frame-navigate-expected.txt View 1 1 chunk +41 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-main-frame-navigated.html View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-main-frame-navigated-expected.txt View 1 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-multiple-frames.html View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/navigator-multiple-frames-expected.txt View 1 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/empty-frame.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/empty-page.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/magic-frame.html View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/magic-script.js View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/bindings/resources/magic-style.css View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 28 (20 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-03-07 02:15:27 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-03-07 20:05:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735933002/40001
3 years, 9 months ago (2017-03-08 00:25:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/396578)
3 years, 9 months ago (2017-03-08 01:57:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735933002/60001
3 years, 9 months ago (2017-03-08 18:04:21 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/166888) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-08 18:07:23 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735933002/80001
3 years, 9 months ago (2017-03-08 19:31:11 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 20:39:05 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f4fbdf6154d37fcb940bfd37b15b...

Powered by Google App Engine
This is Rietveld 408576698