Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2735893002:
Add [Measure] to HTMLInputElement |capture| (Closed)
|
Created:
3 years, 9 months ago by mcasas Modified:
3 years, 9 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd [Measure] to HTMLInputElement |capture|
To follow up usage before and after latest update
to the http://www.w3.org/TR/html-media-capture/ spec.
BUG=698853
Review-Url: https://codereview.chromium.org/2735893002
Cr-Commit-Position: refs/heads/master@{#455243}
Committed: https://chromium.googlesource.com/chromium/src/+/13d368e40bd49f076abb109ea3c875215098f744
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 25 (18 generated)
Description was changed from ========== Add [Measure] to HTMLInputCapture |capture| ========== to ========== Add [Measure] to HTMLInputCapture |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add [Measure] to HTMLInputCapture |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. ========== to ========== Add [Measure] to HTMLInputElement |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. ==========
Patchset #1 (id:20001) has been deleted
The CQ bit was checked by mcasas@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add [Measure] to HTMLInputElement |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. ========== to ========== Add [Measure] to HTMLInputElement |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. BUG=698853 ==========
mcasas@chromium.org changed reviewers: + jochen@chromium.org
jochen@ RS plz
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
lgtm
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by mcasas@chromium.org
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h:
While running git apply --index -p1;
error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1477
error: third_party/WebKit/Source/core/frame/UseCounter.h: patch does not apply
Patch: third_party/WebKit/Source/core/frame/UseCounter.h
Index: third_party/WebKit/Source/core/frame/UseCounter.h
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h
b/third_party/WebKit/Source/core/frame/UseCounter.h
index
97f324bb1c82d74e270c6e24de23aa5d48750bd6..6f7a89e4c3382a892cfea962b1e8e63355365a2c
100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.h
+++ b/third_party/WebKit/Source/core/frame/UseCounter.h
@@ -1477,6 +1477,8 @@ class CORE_EXPORT UseCounter {
ScrollByTouch = 1847,
ScrollByWheel = 1848,
ScheduledActionIgnored = 1849,
+ V8HTMLInputElement_Capture_AttributeGetter = 1850,
+ V8HTMLInputElement_Capture_AttributeSetter = 1851,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2735893002/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488916101887370,
"parent_rev": "345bcb2b409d56a3db4466b5f17bc24224b016c7", "commit_rev":
"13d368e40bd49f076abb109ea3c875215098f744"}
Message was sent while issue was closed.
Description was changed from ========== Add [Measure] to HTMLInputElement |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. BUG=698853 ========== to ========== Add [Measure] to HTMLInputElement |capture| To follow up usage before and after latest update to the http://www.w3.org/TR/html-media-capture/ spec. BUG=698853 Review-Url: https://codereview.chromium.org/2735893002 Cr-Commit-Position: refs/heads/master@{#455243} Committed: https://chromium.googlesource.com/chromium/src/+/13d368e40bd49f076abb109ea3c8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/13d368e40bd49f076abb109ea3c8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
