Issue 2735853005: Check NTP resources only for mobile platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2735853005: Check NTP resources only for mobile platforms (Closed)

Created:
3 years, 9 months ago by Marc Treib

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/3029

Project:
chromium

Visibility:
Public.

Check NTP resources only for mobile platforms Currently, only mobile platforms have resources that can be checked. This CL prevents attempts to test resources for non-mobile releases. (This is the way it has always been intended) BUG=698824 Review-Url: https://codereview.chromium.org/2731403003 Cr-Commit-Position: refs/heads/master@{#455054} (cherry picked from commit b98454a19f315047195fae5e6e4fd11a11e293d2) Review-Url: https://codereview.chromium.org/2735853005 . Cr-Commit-Position: refs/branch-heads/3029@{#60} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/b3f74617f5bec1f4cb23f3b14b9a4c5300c9e32d

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	components/ntp_tiles/popular_sites_impl_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Marc Treib

3 years, 9 months ago (2017-03-08 11:18:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b3f74617f5bec1f4cb23f3b14b9a4c5300c9e32d.