Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2731403003: Check NTP resources only for mobile platforms (Closed)

Created:
3 years, 9 months ago by fhorschig
Modified:
3 years, 9 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check NTP resources only for mobile platforms Currently, only mobile platforms have resources that can be checked. This CL prevents attempts to test resources for non-mobile releases. (This is the way it has always been intended) BUG=698824 Review-Url: https://codereview.chromium.org/2731403003 Cr-Commit-Position: refs/heads/master@{#455054} Committed: https://chromium.googlesource.com/chromium/src/+/b98454a19f315047195fae5e6e4fd11a11e293d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_tiles/popular_sites_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
fhorschig
Hi Marc, would you please take a look at this one-line regression fix?
3 years, 9 months ago (2017-03-07 09:18:19 UTC) #2
Marc Treib
lgtm
3 years, 9 months ago (2017-03-07 09:19:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731403003/1
3 years, 9 months ago (2017-03-07 10:03:00 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 10:07:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b98454a19f315047195fae5e6e4f...

Powered by Google App Engine
This is Rietveld 408576698