Offset scissor and viewport when using SetDrawRectangle on surface.

Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735853002
Cr-Commit-Position: refs/heads/master@{#455610}
Committed: https://chromium.googlesource.com/chromium/src/+/974594311dcca2f77edf9d5b72d6cdbf58b1303e

[jbauman, 2017-03-06 22:15:50]

Description was changed from

==========
Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
==========

to

==========
Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-03-06 22:15:57]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 22:16:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 22:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 22:20:20]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[jbauman, 2017-03-06 23:46:13]

Description was changed from

==========
Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2017-03-06 23:46:18]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 23:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:18:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 01:18:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jbauman, 2017-03-07 03:15:58]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 03:16:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 06:18:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 06:18:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jbauman, 2017-03-07 22:55:31]

jbauman@chromium.org changed reviewers:
+ zmo@chromium.org

[Zhenyao Mo, 2017-03-08 17:51:55]

On 2017/03/07 22:55:32, jbauman wrote:

lgtm

[Zhenyao Mo, 2017-03-08 18:03:48]

On 2017/03/08 17:51:55, Zhenyao Mo wrote:
> On 2017/03/07 22:55:32, jbauman wrote:
> 
> lgtm

By the way, have you searched if there are other calls of glViewport and
glScissor in command buffer other than gles2_decoder.cc?

[jbauman, 2017-03-08 23:22:05]

On 2017/03/08 18:03:48, Zhenyao Mo wrote:
> On 2017/03/08 17:51:55, Zhenyao Mo wrote:
> > On 2017/03/07 22:55:32, jbauman wrote:
> > 
> > lgtm
> 
> By the way, have you searched if there are other calls of glViewport and
> glScissor in command buffer other than gles2_decoder.cc?

Yeah, there are others, but I don't think any of them are relevant to drawing to
the default framebuffer (mainly for drawing to framebuffers that we're copying
to).

[jbauman, 2017-03-08 23:22:18]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:22:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 00:27:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489015338452800,
"parent_rev": "f3aafdc5ac1a6caf52c6c41615118e381ad9e549", "commit_rev":
"974594311dcca2f77edf9d5b72d6cdbf58b1303e"}

[commit-bot: I haz the power, 2017-03-09 00:29:21]

Description was changed from

==========
Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Offset scissor and viewport when using SetDrawRectangle on surface.

IDCompositionSurfaces get an update offset when SetDrawRectangle is
called on them. Whenever the context changes to make the default surface
current then the viewport and scissor must be offset by that amount for
drawing to behave correctly. When switching away from the default
framebuffer it needs to use the normal values again.

BUG=678800
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735853002
Cr-Commit-Position: refs/heads/master@{#455610}
Committed:
https://chromium.googlesource.com/chromium/src/+/974594311dcca2f77edf9d5b72d6...
==========

[commit-bot: I haz the power, 2017-03-09 00:29:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/974594311dcca2f77edf9d5b72d6...