[heap] Start concurrent marking simultaneously with incremental marking.

[heap] Start concurrent marking simultaneously with incremental marking.

This patch hooks up concurrent marking (behind the flag) with the rest
of the GC:
1. Incremental marking spawns concurrent marking task seeded with the
root set.
2. Mark-compact waits for concurrent marking tasks to finish.
3. Scavenger does fast promotion if concurrent marking is pending.

BUG=chromium:694255
Review-Url: https://codereview.chromium.org/2735803005
Cr-Commit-Position: refs/heads/master@{#44526}
Committed: https://chromium.googlesource.com/v8/v8/+/3477957ecd2cc69a6a264938fe57618e69cad05c

[ulan, 2017-03-07 11:53:59]

ulan@chromium.org changed reviewers:
+ hpayer@chromium.org, mlippautz@chromium.org

[ulan, 2017-03-07 11:54:00]

ptal

[Hannes Payer (out of office), 2017-03-08 12:58:50]

You also need to wait for the threads on isolate shutdown. 

LGTM

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
File src/heap/concurrent-marking.h (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
src/heap/concurrent-marking.h:31: bool IsMarkingInProgress() { return
is_task_pending_; }
IsInProgress

https://codereview.chromium.org/2735803005/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:784: if (FLAG_concurrent_marking &&
Maybe we should have an EnsureMarkingCompleted() method then it would be similar
to sweeping.

[Michael Lippautz, 2017-03-08 19:14:34]

lgtm

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
File src/heap/concurrent-marking.cc (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
src/heap/concurrent-marking.cc:99: double start_time_ms =
heap_->MonotonicallyIncreasingTimeInMs();
nit: There's TimedScope in utils-inl.h
e.g.
  double t = 0.0;
  {
    TimedScope scope(&t);
    ...
  }

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
File src/heap/concurrent-marking.h (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
src/heap/concurrent-marking.h:36: base::Semaphore pending_task_semaphore_;
super nit (feel free to ignore): We could align naming with Sweeper here (names
are pending_sweeper_tasks_semaphore_ , sweeping_in_progress_)

https://codereview.chromium.org/2735803005/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1350: concurrent_marking_->IsMarkingInProgress())) {
IsMarkingInProgress should imply FLAG_concurrent_marking?

[ulan, 2017-03-10 16:45:27]

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
File src/heap/concurrent-marking.cc (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
src/heap/concurrent-marking.cc:99: double start_time_ms =
heap_->MonotonicallyIncreasingTimeInMs();
On 2017/03/08 19:14:34, Michael Lippautz wrote:
> nit: There's TimedScope in utils-inl.h
> e.g.
>   double t = 0.0;
>   {
>     TimedScope scope(&t);
>     ...
>   }

Done.

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
File src/heap/concurrent-marking.h (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
src/heap/concurrent-marking.h:31: bool IsMarkingInProgress() { return
is_task_pending_; }
On 2017/03/08 12:58:50, Hannes Payer wrote:
> IsInProgress

I named it IsTaskPending().

https://codereview.chromium.org/2735803005/diff/20001/src/heap/concurrent-mar...
src/heap/concurrent-marking.h:36: base::Semaphore pending_task_semaphore_;
On 2017/03/08 19:14:34, Michael Lippautz wrote:
> super nit (feel free to ignore): We could align naming with Sweeper here
(names
> are pending_sweeper_tasks_semaphore_ , sweeping_in_progress_)

We will probably (re-)start the tasks multiple times in one marking round. I'll
keep the flag task specific.

https://codereview.chromium.org/2735803005/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1350: concurrent_marking_->IsMarkingInProgress())) {
On 2017/03/08 19:14:34, Michael Lippautz wrote:
> IsMarkingInProgress should imply FLAG_concurrent_marking?

Done.

https://codereview.chromium.org/2735803005/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2735803005/diff/20001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:784: if (FLAG_concurrent_marking &&
On 2017/03/08 12:58:50, Hannes Payer wrote:
> Maybe we should have an EnsureMarkingCompleted() method then it would be
similar
> to sweeping.

Done.

[ulan, 2017-03-10 16:47:14]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-03-10 16:47:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2735803005/#ps80001
(title: "remove leftover")

[commit-bot: I haz the power, 2017-03-10 16:47:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 16:52:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:52:05]

Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[ulan, 2017-04-10 13:46:36]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-04-10 13:46:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2735803005/#ps100001
(title: "fix test")

[commit-bot: I haz the power, 2017-04-10 13:46:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2017-04-10 13:54:32]

The CQ bit was checked by ulan@chromium.org

[ulan, 2017-04-10 13:54:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/2735803005/#ps120001
(title: "fix test")

[commit-bot: I haz the power, 2017-04-10 13:54:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:22:31]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491832472490360,
"parent_rev": "85b1f108c577fe5ef78890da26fd71db5eddc8a7", "commit_rev":
"3477957ecd2cc69a6a264938fe57618e69cad05c"}

[commit-bot: I haz the power, 2017-04-10 14:22:36]

Description was changed from

==========
[heap] Start concurrent marking simultaneously with incremental marking.

This patch hooks up concurrent marking (behind the flag) with the rest
of the GC:
1. Incremental marking spawns concurrent marking task seeded with the
root set.
2. Mark-compact waits for concurrent marking tasks to finish.
3. Scavenger does fast promotion if concurrent marking is pending.

BUG=chromium:694255
==========

to

==========
[heap] Start concurrent marking simultaneously with incremental marking.

This patch hooks up concurrent marking (behind the flag) with the rest
of the GC:
1. Incremental marking spawns concurrent marking task seeded with the
root set.
2. Mark-compact waits for concurrent marking tasks to finish.
3. Scavenger does fast promotion if concurrent marking is pending.

BUG=chromium:694255

Review-Url: https://codereview.chromium.org/2735803005
Cr-Commit-Position: refs/heads/master@{#44526}
Committed:
https://chromium.googlesource.com/v8/v8/+/3477957ecd2cc69a6a264938fe57618e69c...
==========

[commit-bot: I haz the power, 2017-04-10 14:22:37]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/3477957ecd2cc69a6a264938fe57618e69c...