Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2735703003: Add message loop to v8's unittests (Closed)

Created:
3 years, 9 months ago by ckulakowski
Modified:
3 years, 9 months ago
Reviewers:
jam, Paweł Hajdan Jr.
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add message loop to v8's unittests When (at least some) v8 unittests are started in bigger batch we hit v8 garbage collector's incremental marking hard limit. When it happens v8's engine posts task and it causes crash as there is no active message loop. This change creates message loop for v8's unittests to fix this crash. BUG=695374 Review-Url: https://codereview.chromium.org/2735703003 Cr-Commit-Position: refs/heads/master@{#454898} Committed: https://chromium.googlesource.com/chromium/src/+/798c699f3c8ca93487d257d7eda0a59b35ee1d9e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/test/base/v8_unit_test.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/test/base/v8_unit_test.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ckulakowski
3 years, 9 months ago (2017-03-06 12:48:02 UTC) #3
Paweł Hajdan Jr.
LGTM + jam@ FYI
3 years, 9 months ago (2017-03-06 17:37:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735703003/1
3 years, 9 months ago (2017-03-06 18:10:50 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:41:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/798c699f3c8ca93487d257d7eda0...

Powered by Google App Engine
This is Rietveld 408576698