Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: chrome/test/base/v8_unit_test.cc

Issue 2735703003: Add message loop to v8's unittests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/v8_unit_test.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/v8_unit_test.cc
diff --git a/chrome/test/base/v8_unit_test.cc b/chrome/test/base/v8_unit_test.cc
index 92c3ae5834728e7920afddb2b6bf1fcc9092b2c3..2e7976a144c5f00bfe0cda985f6e6593b59aa2cf 100644
--- a/chrome/test/base/v8_unit_test.cc
+++ b/chrome/test/base/v8_unit_test.cc
@@ -6,6 +6,8 @@
#include "base/files/file_util.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
#include "base/path_service.h"
#include "base/strings/string_piece.h"
#include "base/strings/stringprintf.h"
@@ -192,6 +194,8 @@ void V8UnitTest::SetUp() {
console->Set(v8::String::NewFromUtf8(isolate, "error"), error_function);
context_.Reset(isolate, v8::Context::New(isolate, NULL, global));
+
+ loop_ = base::MakeUnique<base::MessageLoop>();
}
void V8UnitTest::SetGlobalStringVar(const std::string& var_name,
« no previous file with comments | « chrome/test/base/v8_unit_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698