Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2735683002: Network traffic annotation added to remoting/test. (Closed)

Created:
3 years, 9 months ago by Ramin Halavati
Modified:
3 years, 9 months ago
Reviewers:
Jamie, joedow
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to remoting/test. Network traffic annotation is added to network request of remoting/test. BUG=656607 Review-Url: https://codereview.chromium.org/2735683002 Cr-Commit-Position: refs/heads/master@{#455049} Committed: https://chromium.googlesource.com/chromium/src/+/fa6895bd3981268c0f9fea4086cb547ece8ccffc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M remoting/test/app_remoting_report_issue_request.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/test/host_list_fetcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M remoting/test/remote_host_info_fetcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Ramin Halavati
As you have seen in https://codereview.chromium.org/2737463002 and https://codereview.chromium.org/2737463002 we are adding annotation to network requests. ...
3 years, 9 months ago (2017-03-06 09:22:19 UTC) #2
joedow
lgtm
3 years, 9 months ago (2017-03-06 17:07:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735683002/1
3 years, 9 months ago (2017-03-07 08:03:00 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 09:34:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fa6895bd3981268c0f9fea4086cb...

Powered by Google App Engine
This is Rietveld 408576698