Network traffic annotation added to remoting/host.

Network traffic annotation added to remoting/host.

Network traffic annotation is added to network request of
remoting/host.

BUG=656607

[Ramin Halavati, 2017-03-06 09:12:56]

rhalavati@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Ramin Halavati, 2017-03-06 09:12:57]

We are annotating all network requests in Chromium with a new
NetworkTrafficAnnotation scheme. This allows enterprise users of Chrome to audit
the requests and configure Chrome in a way that meets their security policies
and expectations. Furthermore, it allows us to generate better debugging data in
chrome://net-internals and measure bandwidth consumption on a per-request-type
basis.

I've modified 2 files in remoting/base and added annotation template to them.
Please review them and suggest the required answers for the empty parts (marked
with '...'). Please note that the claims should be thorough and covering all
cases. In case you believe that annotation should be passed to the modified
function instead of originating from it, please tell me to change the CL
accordingly.

Please take a look at the protobuf scheme in:
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
for the definition of the annotations.

You can find a sample annotation in:
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...

Entriprise policy options are here:
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/ch...

And more description on enterprise policy settings is here:
http://dev.chromium.org/administrators/policy-list-3

Please tell me if you need any clarifications from my side. If you want to learn
more, see:
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.

[Jamie, 2017-03-06 17:50:43]

On 2017/03/06 09:12:57, Ramin Halavati wrote:
> We are annotating all network requests in Chromium with a new
> NetworkTrafficAnnotation scheme. This allows enterprise users of Chrome to
audit
> the requests and configure Chrome in a way that meets their security policies
> and expectations. Furthermore, it allows us to generate better debugging data
in
> chrome://net-internals and measure bandwidth consumption on a per-request-type
> basis.
> 
> I've modified 2 files in remoting/base and added annotation template to them.
> Please review them and suggest the required answers for the empty parts
(marked
> with '...'). Please note that the claims should be thorough and covering all
> cases. In case you believe that annotation should be passed to the modified
> function instead of originating from it, please tell me to change the CL
> accordingly.
> 
> Please take a look at the protobuf scheme in:
>
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
> for the definition of the annotations.
> 
> You can find a sample annotation in:
>
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...
> 
> Entriprise policy options are here:
>
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/ch...
> 
> And more description on enterprise policy settings is here:
> http://dev.chromium.org/administrators/policy-list-3
> 
> Please tell me if you need any clarifications from my side. If you want to
learn
> more, see:
>
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.

Nothing under remoting/host is linked into Chrome (it's the Chrome Remote
Desktop host component, which ships separately), so if I'm reading your design
doc correctly, I don't think you need to make this change.

[Ramin Halavati, 2017-03-07 14:38:46]

On 2017/03/06 17:50:43, Jamie wrote:
> On 2017/03/06 09:12:57, Ramin Halavati wrote:
> > We are annotating all network requests in Chromium with a new
> > NetworkTrafficAnnotation scheme. This allows enterprise users of Chrome to
> audit
> > the requests and configure Chrome in a way that meets their security
policies
> > and expectations. Furthermore, it allows us to generate better debugging
data
> in
> > chrome://net-internals and measure bandwidth consumption on a
per-request-type
> > basis.
> > 
> > I've modified 2 files in remoting/base and added annotation template to
them.
> > Please review them and suggest the required answers for the empty parts
> (marked
> > with '...'). Please note that the claims should be thorough and covering all
> > cases. In case you believe that annotation should be passed to the modified
> > function instead of originating from it, please tell me to change the CL
> > accordingly.
> > 
> > Please take a look at the protobuf scheme in:
> >
>
https://cs.chromium.org/chromium/src/tools/traffic_annotation/traffic_annotat...
> > for the definition of the annotations.
> > 
> > You can find a sample annotation in:
> >
>
https://cs.chromium.org/chromium/src/components/spellcheck/browser/spelling_s...
> > 
> > Entriprise policy options are here:
> >
>
https://cs.chromium.org/chromium/src/out/Debug/gen/components/policy/proto/ch...
> > 
> > And more description on enterprise policy settings is here:
> > http://dev.chromium.org/administrators/policy-list-3
> > 
> > Please tell me if you need any clarifications from my side. If you want to
> learn
> > more, see:
> >
>
https://docs.google.com/document/d/1FWEFTHzdqIA1wHUo_DuSpJjppW22otCMPCOA5NumhJU.
> 
> Nothing under remoting/host is linked into Chrome (it's the Chrome Remote
> Desktop host component, which ships separately), so if I'm reading your design
> doc correctly, I don't think you need to make this change.

Thank you very much for clarification. As it is not part of Chromium, we do not
need to annotate it now.

I close the CL.

[Ramin Halavati, 2017-03-07 14:38:58]

Description was changed from

==========
Network traffic annotation added to remoting/host.

Network traffic annotation is added to network request of
remoting/host.

BUG=656607
==========

to

==========
Network traffic annotation added to remoting/host.

Network traffic annotation is added to network request of
remoting/host.

BUG=656607
==========