Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2735653002: Merge M58: Add new sad tab strings. (Closed)

Created:
3 years, 9 months ago by Will Harris
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge M58: Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259, 698368 Review-Url: https://codereview.chromium.org/2730903006 Cr-Original-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa2774980dc4eb Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454698} (cherry picked from commit 16fe9a094fcfeacefe25e768918379cc2419d715) Review-Url: https://codereview.chromium.org/2735653002 . Cr-Commit-Position: refs/branch-heads/3029@{#15} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/c5c307c5f138bc029efdd63b0d8969337b4d30cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M components/new_or_sad_tab_strings.grdp View 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Will Harris
3 years, 9 months ago (2017-03-06 06:25:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5c307c5f138bc029efdd63b0d8969337b4d30cf.

Powered by Google App Engine
This is Rietveld 408576698