Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Issue 2735543002: Separate VisualViewport layer tree creation from attachment. (Closed)

Created:
3 years, 9 months ago by skobes
Modified:
3 years, 9 months ago
Reviewers:
bokan, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, blink-reviews-frames_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Separate VisualViewport layer tree creation from attachment. This paves the way for deferring attachment. With root layer scrolling the layer passed to WebViewImpl::setRootGraphicsLayer will be the LayoutView's main GraphicsLayer, which does not exist until after the compositing update. BUG=698464 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2735543002 Cr-Commit-Position: refs/heads/master@{#454934} Committed: https://chromium.googlesource.com/chromium/src/+/16beff659fc7bc169da48a13d926e05b01053bea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -85 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 2 chunks +21 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 2 chunks +52 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 5 chunks +15 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (28 generated)
skobes
3 years, 9 months ago (2017-03-04 23:37:50 UTC) #26
bokan
lgtm
3 years, 9 months ago (2017-03-06 15:49:22 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735543002/100001
3 years, 9 months ago (2017-03-06 18:24:14 UTC) #29
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:16:35 UTC) #32
Message was sent while issue was closed.
Committed patchset #1 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/16beff659fc7bc169da48a13d926...

Powered by Google App Engine
This is Rietveld 408576698