Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: third_party/WebKit/Source/core/frame/VisualViewport.h

Issue 2735543002: Separate VisualViewport layer tree creation from attachment. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/VisualViewport.h
diff --git a/third_party/WebKit/Source/core/frame/VisualViewport.h b/third_party/WebKit/Source/core/frame/VisualViewport.h
index 0e8ee557dc123b072cea582aa0b6ed2e096a963e..fe34d491e238425029ab429acb4e625305af42cb 100644
--- a/third_party/WebKit/Source/core/frame/VisualViewport.h
+++ b/third_party/WebKit/Source/core/frame/VisualViewport.h
@@ -62,6 +62,25 @@ class LocalFrame;
// mechanisms. Its contents is the page's main FrameView, which corresponds to
// the outer viewport. The inner viewport is always contained in the outer
// viewport and can pan within it.
+//
+// When attached, the tree will look like this:
+//
+// VV::m_rootTransformLayer
+// +- VV::m_innerViewportContainerLayer
+// +- VV::m_overscrollElasticityLayer
+// | +- VV::m_pageScaleLayer
+// | +- VV::m_innerViewportScrollLayer
+// | +-- PLC::m_overflowControlsHostLayer
+// | +-- PLC::m_containerLayer (fixed pos container)
+// | +-- PLC::m_scrollLayer
+// | +-- PLC::m_rootContentLayer
+// | +-- LayoutView CompositedLayerMapping layers
+// +- PageOverlay for InspectorOverlay
+// +- PageOverlay for ColorOverlay
+// +- PLC::m_layerForHorizontalScrollbar
+// +- PLC::m_layerForVerticalScrollbar
+// +- PLC::m_layerForScrollCorner (non-overlay only)
+//
class CORE_EXPORT VisualViewport final
: public GarbageCollectedFinalized<VisualViewport>,
public GraphicsLayerClient,
@@ -76,7 +95,8 @@ class CORE_EXPORT VisualViewport final
DECLARE_VIRTUAL_TRACE();
- void attachToLayerTree(GraphicsLayer*);
+ void createLayerTree();
+ void attachLayerTree(GraphicsLayer*);
GraphicsLayer* rootGraphicsLayer() { return m_rootTransformLayer.get(); }
GraphicsLayer* containerLayer() {

Powered by Google App Engine
This is Rietveld 408576698