Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8715)

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.h

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/metrics/cast_metrics_service_client.h
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.h b/chromecast/browser/metrics/cast_metrics_service_client.h
index a45cee9c58b2e8fd05b3158234c8a25748cb4b58..655448015d576b468e6c92d50e7ee6ad1cd2cf77 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.h
+++ b/chromecast/browser/metrics/cast_metrics_service_client.h
@@ -80,8 +80,8 @@ class CastMetricsServiceClient : public ::metrics::MetricsServiceClient,
void CollectFinalMetricsForLog(const base::Closure& done_callback) override;
std::string GetMetricsServerUrl() override;
std::unique_ptr<::metrics::MetricsLogUploader> CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ const base::StringPiece& server_url,
+ const base::StringPiece& mime_type,
::metrics::MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) override;
base::TimeDelta GetStandardUploadInterval() override;

Powered by Google App Engine
This is Rietveld 408576698