Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 965168fed133c7d0f932b5d4c13b531fff0557b0..1897ae867e30bd82f3eb1fd73762bc429fc732b1 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -514,8 +514,8 @@ void ChromeMetricsServiceClient::CollectFinalMetricsForLog(
std::unique_ptr<metrics::MetricsLogUploader>
ChromeMetricsServiceClient::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ const base::StringPiece& server_url,
+ const base::StringPiece& mime_type,
metrics::MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) {
return std::unique_ptr<metrics::MetricsLogUploader>(

Powered by Google App Engine
This is Rietveld 408576698