Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 2735443003: Use StringPiece for CreateUploader/NetMetricsLogUploader params. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/metrics/cast_metrics_service_client.cc
diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc
index 0d61688a36f3e3cc2bfba28baba5562a807ebf54..eee2b0106814ff86d0ad40cec6edbc00745887d4 100644
--- a/chromecast/browser/metrics/cast_metrics_service_client.cc
+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc
@@ -243,8 +243,8 @@ std::string CastMetricsServiceClient::GetMetricsServerUrl() {
std::unique_ptr<::metrics::MetricsLogUploader>
CastMetricsServiceClient::CreateUploader(
- const std::string& server_url,
- const std::string& mime_type,
+ const base::StringPiece& server_url,
+ const base::StringPiece& mime_type,
::metrics::MetricsLogUploader::MetricServiceType service_type,
const base::Callback<void(int)>& on_upload_complete) {
return std::unique_ptr<::metrics::MetricsLogUploader>(

Powered by Google App Engine
This is Rietveld 408576698