Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2735413002: Select-to-speak event handler should be on root window, not ash Shell. (Closed)

Created:
3 years, 9 months ago by dmazzoni
Modified:
3 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Select-to-speak event handler should be on root window, not ash Shell. Otherwise we miss out on the virtual keyboard. This change alone won't fix the virtual keyboard but it's a necessary piece of the fix. Tested manually by debugging and seeing that we're getting mouse events over the virtual keyboard now. BUG=699617 Review-Url: https://codereview.chromium.org/2735413002 Cr-Commit-Position: refs/heads/master@{#456408} Committed: https://chromium.googlesource.com/chromium/src/+/2404b8fb3068d18de9068c4e446344cc5aa3a2cb

Patch Set 1 #

Patch Set 2 : Get rid of unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
dmazzoni
3 years, 9 months ago (2017-03-08 18:43:06 UTC) #4
dmazzoni
Friendly ping on this one
3 years, 9 months ago (2017-03-10 20:57:02 UTC) #11
David Tseng
lgtm
3 years, 9 months ago (2017-03-10 20:59:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735413002/20001
3 years, 9 months ago (2017-03-13 16:34:14 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 17:11:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2404b8fb3068d18de9068c4e4463...

Powered by Google App Engine
This is Rietveld 408576698