Make all DDC internal stack traces apply source maps.

Make all DDC internal stack traces apply source maps.

Make DDC a better platform for debugging by ensuring that stack traces
generated by DDC even when using the raw dart:core StackTrace class
apply JS source maps and benefit from the polish provided by the
stack_trace package.

stack_trace_mapper.dart needs to be compiled to js and included on your
page to benefit from this functionality. Otherwise you will still see
regular JS stack traces as usual.

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/sdk/commit/7ba7e0cee61299dd10382a063017426302a390bb

[Jacob, 2017-03-08 02:56:01]

jacobr@google.com changed reviewers:
+ vsm@google.com

[Jacob, 2017-03-08 02:56:02]

Make all DDC internal stack traces apply source maps.

Make DDC a better platform for debugging by ensuring that stack traces
generated by DDC even when using the raw dart:core StackTrace class
apply JS source maps and benefit from the polish provided by the
stack_trace package.

stack_trace_mapper.dart needs to be compiled to js and included on your
page to benefit from this functionality. Otherwise you will still see
regular JS stack traces as usual.

[Jacob, 2017-03-08 02:58:14]

https://codereview.chromium.org/2735303002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2735303002/diff/1/DEPS#newcode109
DEPS:109: "stack_trace_tag": "@1.7.2",
I've landed fixes to these two packages needed for this CL.

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/tool/input...
File pkg/dev_compiler/tool/input_sdk/private/js_helper.dart (right):

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/tool/input...
pkg/dev_compiler/tool/input_sdk/private/js_helper.dart:637: if (_trace != null)
return _trace;
no idea why this JS macro was used.

[vsm, 2017-03-08 15:34:44]

nice!

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
File pkg/dev_compiler/web/stack_trace_mapper.dart (right):

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
pkg/dev_compiler/web/stack_trace_mapper.dart:37: /// Global object DDC uses to
see if a stack trace utility has been registed.
registed -> registered

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
pkg/dev_compiler/web/stack_trace_mapper.dart:115: throw new StateError('Souce
maps are not done loading.');
Souce -> Source

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
pkg/dev_compiler/web/stack_trace_mapper.dart:124: for (ScriptElement script in
scripts) {
Would it make more sense to do this in the bootstrap code (where we inject the
DDC script tags)?

If we ever defer loading of DDC modules, it may make sense to pair code and
source map more tightly.

[Jacob, 2017-03-09 02:28:42]

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
File pkg/dev_compiler/web/stack_trace_mapper.dart (right):

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
pkg/dev_compiler/web/stack_trace_mapper.dart:37: /// Global object DDC uses to
see if a stack trace utility has been registed.
On 2017/03/08 15:34:44, vsm wrote:
> registed -> registered

Done.

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
pkg/dev_compiler/web/stack_trace_mapper.dart:115: throw new StateError('Souce
maps are not done loading.');
On 2017/03/08 15:34:44, vsm wrote:
> Souce -> Source

Done.

Clealy my compute keyboad 'r' key needs to be replaced.

https://codereview.chromium.org/2735303002/diff/1/pkg/dev_compiler/web/stack_...
pkg/dev_compiler/web/stack_trace_mapper.dart:124: for (ScriptElement script in
scripts) {
On 2017/03/08 15:34:44, vsm wrote:
> Would it make more sense to do this in the bootstrap code (where we inject the
> DDC script tags)?
> 
> If we ever defer loading of DDC modules, it may make sense to pair code and
> source map more tightly.
> 

Good point. 
I've switched up the code so the API is now that the user calls
loadSourceMaps(List<String> scripts, callback)
that way if we support deferred loading we can just have the deferred
loading code just call
loadSourceMaps([deferred scripts], callback)
and everything will work.

[vsm, 2017-03-09 02:56:17]

lgtm

[Jacob, 2017-03-09 03:13:09]

Description was changed from

==========
Make all DDC internal stack traces apply source maps.

Make DDC a better platform for debugging by ensuring that stack traces
generated by DDC even when using the raw dart:core StackTrace class
apply JS source maps and benefit from the polish provided by the
stack_trace package.

stack_trace_mapper.dart needs to be compiled to js and included on your
page to benefit from this functionality. Otherwise you will still see
regular JS stack traces as usual.

BUG=
==========

to

==========
Make all DDC internal stack traces apply source maps.

Make DDC a better platform for debugging by ensuring that stack traces
generated by DDC even when using the raw dart:core StackTrace class
apply JS source maps and benefit from the polish provided by the
stack_trace package.

stack_trace_mapper.dart needs to be compiled to js and included on your
page to benefit from this functionality. Otherwise you will still see
regular JS stack traces as usual.

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7ba7e0cee61299dd10382a063017426302a390bb
==========

[Jacob, 2017-03-09 03:13:10]

Committed patchset #2 (id:20001) manually as
7ba7e0cee61299dd10382a063017426302a390bb (presubmit successful).