Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: pkg/dev_compiler/lib/js/common/dart_sdk.js

Issue 2735303002: Make all DDC internal stack traces apply source maps. (Closed)
Patch Set: Make all DDC internal stack traces apply source maps. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « pkg/dev_compiler/lib/js/amd/dart_sdk.js ('k') | pkg/dev_compiler/lib/js/es6/dart_sdk.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/js/common/dart_sdk.js
diff --git a/pkg/dev_compiler/lib/js/common/dart_sdk.js b/pkg/dev_compiler/lib/js/common/dart_sdk.js
index 565d954810f4bfa2a12151e4c5e4264ea309deff..65cfa06c871da78a64aeb8594ffaa98ae3cee31a 100644
--- a/pkg/dev_compiler/lib/js/common/dart_sdk.js
+++ b/pkg/dev_compiler/lib/js/common/dart_sdk.js
@@ -4070,6 +4070,13 @@ dart.setSignature(_debugger.TypeFormatter, {
children: dart.definiteFunctionType(core.List$(_debugger.NameValuePair), [dart.dynamic])
})
});
+_debugger.StackTraceMapper = dart.typedef('StackTraceMapper', () => dart.functionType(core.String, [core.String]));
+dart.copyProperties(_debugger, {
+ get stackTraceMapper() {
+ let _util = dart.global.$dartStackTraceUtility;
+ return _debugger.StackTraceMapper._check(_util != null ? _util.mapper : null);
+ }
+});
_debugger.registerDevtoolsFormatter = function() {
let formatters = JSArrayOfJsonMLFormatter().of([_debugger._devtoolsFormatter]);
dart.global.devtoolsFormatters = formatters;
@@ -11939,6 +11946,9 @@ _js_helper._StackTrace = class _StackTrace extends core.Object {
let trace = null;
if (this[_exception] !== null && typeof this[_exception] === "object") {
trace = this[_exception].stack;
+ if (trace != null && _debugger.stackTraceMapper != null) {
+ trace = _debugger.stackTraceMapper(trace);
+ }
}
return this[_trace] = trace == null ? '' : trace;
}
« no previous file with comments | « pkg/dev_compiler/lib/js/amd/dart_sdk.js ('k') | pkg/dev_compiler/lib/js/es6/dart_sdk.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698