Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/js_helper.dart

Issue 2735303002: Make all DDC internal stack traces apply source maps. (Closed)
Patch Set: Make all DDC internal stack traces apply source maps. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/debugger.dart ('k') | pkg/dev_compiler/web/stack_trace_mapper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/tool/input_sdk/private/js_helper.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart b/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart
index fee11a52f8618a00153bec37387627ffe2791509..28cd859ebd87077efe41558ab01a796d0eaf4767 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/js_helper.dart
@@ -6,6 +6,8 @@ library dart._js_helper;
import 'dart:collection';
+import 'dart:_debugger' show stackTraceMapper;
+
import 'dart:_foreign_helper' show
JS,
JS_STRING_CONCAT;
@@ -628,15 +630,19 @@ StackTrace getTraceFromException(exception) => new _StackTrace(exception);
class _StackTrace implements StackTrace {
var _exception;
String _trace;
+
_StackTrace(this._exception);
String toString() {
- if (_trace != null) return JS('String', '#', _trace);
+ if (_trace != null) return _trace;
String trace;
if (JS('bool', '# !== null', _exception) &&
JS('bool', 'typeof # === "object"', _exception)) {
trace = JS("String|Null", r"#.stack", _exception);
+ if (trace != null && stackTraceMapper != null) {
+ trace = stackTraceMapper(trace);
+ }
}
return _trace = (trace == null) ? '' : trace;
}
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/debugger.dart ('k') | pkg/dev_compiler/web/stack_trace_mapper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698