Rename *isOverWidget* methods to ...isOverFrameViewBase...

Rename *isOverWidget* methods to ...isOverFrameViewBase...

BUG=697351
Review-Url: https://codereview.chromium.org/2735293002
Cr-Commit-Position: refs/heads/master@{#455950}
Committed: https://chromium.googlesource.com/chromium/src/+/062a43cf645faf5a158afa6657bb85b6a5ebd6a8

[joelhockey, 2017-03-08 02:39:40]

joelhockey@chromium.org changed reviewers:
+ slangley@chromium.org

[joelhockey, 2017-03-08 02:39:45]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 02:40:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slangley, 2017-03-08 03:42:41]

lgtm

[joelhockey, 2017-03-08 03:45:04]

joelhockey@chromium.org changed reviewers:
+ haraken@chromium.org

[joelhockey, 2017-03-08 03:45:04]

haraken ptal

[commit-bot: I haz the power, 2017-03-08 03:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:59:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2017-03-08 06:19:07]

LGTM

https://codereview.chromium.org/2735293002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/ScrollManager.h (right):

https://codereview.chromium.org/2735293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/ScrollManager.h:98: WebInputEventResult
passScrollGestureEventToFrameViewBase(

Maybe we could drop "ToFrameViewBase" to make it less verbose.

https://codereview.chromium.org/2735293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/ScrollManager.h:125: bool
m_lastGestureScrollOverFrameViewBase;

Maybe drop "OverFrameViewBase".

[joelhockey, 2017-03-08 06:42:36]

https://codereview.chromium.org/2735293002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/ScrollManager.h (right):

https://codereview.chromium.org/2735293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/ScrollManager.h:98: WebInputEventResult
passScrollGestureEventToFrameViewBase(
On 2017/03/08 06:19:06, haraken wrote:
> 
> Maybe we could drop "ToFrameViewBase" to make it less verbose.

Done.  Yes, the parameters make it clear enought that the gesture is being
passed to
LayoutObject / LayoutPart / FrameViewBase.

https://codereview.chromium.org/2735293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/ScrollManager.h:125: bool
m_lastGestureScrollOverFrameViewBase;
On 2017/03/08 06:19:06, haraken wrote:
> 
> Maybe drop "OverFrameViewBase".

I'll leave this for now.  I did think about making it shorter, but I judged that
anything shorter becomes ambiguous and so even though this is a long name, it
did help me understand the code.

[joelhockey, 2017-03-08 06:42:48]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-08 06:42:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2735293002/#ps20001
(title: "Rename *isOverWidget* methods to ...isOverFrameViewBase...")

[commit-bot: I haz the power, 2017-03-08 06:43:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 07:15:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:15:01]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-03-08 07:23:51]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:24:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 07:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:56:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-03-08 09:41:25]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-08 09:41:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 09:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 09:45:28]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-03-08 10:23:00]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-03-08 10:23:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2735293002/#ps40001
(title: "Rename *isOverWidget* methods to ...isOverFrameViewBase...")

[commit-bot: I haz the power, 2017-03-08 10:23:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 11:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 11:41:37]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-03-08 11:49:04]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-08 11:49:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 12:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 12:25:48]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[joelhockey, 2017-03-09 23:52:24]

The CQ bit was checked by joelhockey@chromium.org

[commit-bot: I haz the power, 2017-03-09 23:53:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 01:31:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489103544824180,
"parent_rev": "d4523043de7614ef55438aaa42fadafb905a0e56", "commit_rev":
"062a43cf645faf5a158afa6657bb85b6a5ebd6a8"}

[commit-bot: I haz the power, 2017-03-10 01:35:11]

Description was changed from

==========
Rename *isOverWidget* methods to ...isOverFrameViewBase...

BUG=697351
==========

to

==========
Rename *isOverWidget* methods to ...isOverFrameViewBase...

BUG=697351

Review-Url: https://codereview.chromium.org/2735293002
Cr-Commit-Position: refs/heads/master@{#455950}
Committed:
https://chromium.googlesource.com/chromium/src/+/062a43cf645faf5a158afa6657bb...
==========

[commit-bot: I haz the power, 2017-03-10 01:35:13]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/062a43cf645faf5a158afa6657bb...