Rename *isOverWidget* methods to ...isOverFrameViewBase...

third_party/WebKit/Source/core/input/ScrollManager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScrollManager_h
 #define ScrollManager_h
 
 #include "core/CoreExport.h"
 #include "core/page/EventWithHitTestResults.h"
 #include "platform/geometry/LayoutSize.h"
@@ skipping 77 matching lines @@
   void resize(const WebMouseEvent&);
   // Clears |m_resizeScrollableArea|. if |shouldNotBeNull| is true this
   // function DCHECKs to make sure that variable is indeed not null.
   void clearResizeScrollableArea(bool shouldNotBeNull);
   void setResizeScrollableArea(PaintLayer*, IntPoint);
 
  private:
   WebInputEventResult handleGestureScrollUpdate(const WebGestureEvent&);
   WebInputEventResult handleGestureScrollBegin(const WebGestureEvent&);
 
-  WebInputEventResult passScrollGestureEventToWidget(const WebGestureEvent&,
-                                                     LayoutObject*);
+  WebInputEventResult passScrollGestureEventToFrameViewBase(

[haraken, 2017/03/08 06:19:06]

Maybe we could drop "ToFrameViewBase" to make it less verbose.

[joelhockey, 2017/03/08 06:42:36]

Done.  Yes, the parameters make it clear enought that the gesture is being
passed to
LayoutObject / LayoutPart / FrameViewBase.

+      const WebGestureEvent&,
+      LayoutObject*);
 
   void clearGestureScrollState();
 
   void customizedScroll(const Node& startNode, ScrollState&);
 
   FrameHost* frameHost() const;
 
   bool isViewportScrollingElement(const Element&) const;
 
   bool handleScrollGestureOnResizer(Node*, const WebGestureEvent&);
 
   void recomputeScrollChain(const Node& startNode,
                             std::deque<int>& scrollChain);
 
   // NOTE: If adding a new field to this class please ensure that it is
   // cleared in |ScrollManager::clear()|.
 
   const Member<LocalFrame> m_frame;
 
   // Only used with the ScrollCustomization runtime enabled feature.
   std::deque<int> m_currentScrollChain;
 
   Member<Node> m_scrollGestureHandlingNode;
 
-  bool m_lastGestureScrollOverWidget;
+  bool m_lastGestureScrollOverFrameViewBase;

[haraken, 2017/03/08 06:19:06]

Maybe drop "OverFrameViewBase".

[joelhockey, 2017/03/08 06:42:36]

I'll leave this for now.  I did think about making it shorter, but I judged that
anything shorter becomes ambiguous and so even though this is a long name, it
did help me understand the code.

 
   // The most recent element to scroll natively during this scroll
   // sequence. Null if no native element has scrolled this scroll
   // sequence, or if the most recent element to scroll used scroll
   // customization.
   Member<Element> m_previousGestureScrolledElement;
 
   // True iff some of the delta has been consumed for the current
   // scroll sequence in this frame, or any child frames. Only used
   // with ScrollCustomization. If some delta has been consumed, a
   // scroll which shouldn't propagate can't cause any element to
   // scroll other than the |m_previousGestureScrolledNode|.
   bool m_deltaConsumedForScrollSequence;
 
   Member<Scrollbar> m_scrollbarHandlingScrollGesture;
 
   Member<PaintLayerScrollableArea> m_resizeScrollableArea;
 
   LayoutSize
       m_offsetFromResizeCorner;  // In the coords of m_resizeScrollableArea.
 };
 
 }  // namespace blink
 
 #endif  // ScrollManager_h