Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2735173003: aw: Do not DumpWithoutCrashing if crash reporter is not enabled. (Closed)

Created:
3 years, 9 months ago by Tobias Sargeant
Modified:
3 years, 9 months ago
Reviewers:
Torne
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

aw: Do not DumpWithoutCrashing if crash reporter is not enabled. GSA can apparently use the AwDebug reflection interface at a point where WebView (and hence the crash reporter) hasn't been initialized yet. We should just fail in this case. BUG=698243 Review-Url: https://codereview.chromium.org/2729093004 Cr-Commit-Position: refs/heads/master@{#455426} (cherry picked from commit dec2b22c83c792439a84157ee7bc6c900ea89c09) Review-Url: https://codereview.chromium.org/2735173003 . Cr-Commit-Position: refs/branch-heads/3029@{#61} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/689d4697449918c2345e0600cfc85cd89cc45f42

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/common/crash_reporter/aw_microdump_crash_reporter.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735173003/1
3 years, 9 months ago (2017-03-08 11:20:20 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-08 11:20:22 UTC) #4
Tobias Sargeant
3 years, 9 months ago (2017-03-08 11:22:05 UTC) #6
Tobias Sargeant
3 years, 9 months ago (2017-03-08 11:35:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
689d4697449918c2345e0600cfc85cd89cc45f42.

Powered by Google App Engine
This is Rietveld 408576698