Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2729093004:
aw: Do not DumpWithoutCrashing if crash reporter is not enabled. (Closed)
|
Created:
3 years, 9 months ago by Tobias Sargeant Modified:
3 years, 9 months ago Reviewers:
Torne CC:
chromium-reviews, android-webview-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionaw: Do not DumpWithoutCrashing if crash reporter is not enabled.
GSA can apparently use the AwDebug reflection interface at a
point where WebView (and hence the crash reporter) hasn't been
initialized yet. We should just fail in this case.
BUG=698243
Review-Url: https://codereview.chromium.org/2729093004
Cr-Commit-Position: refs/heads/master@{#455426}
Committed: https://chromium.googlesource.com/chromium/src/+/dec2b22c83c792439a84157ee7bc6c900ea89c09
Patch Set 1 #Patch Set 2 : aw: Do not DumpWithoutCrashing if crash reporter is not enabled. #Patch Set 3 : fix compile error #Messages
Total messages: 24 (16 generated)
Description was changed from ========== aw: Do not DumpWithoutCrashing if crash reporter is not enabled. GSA can apparently use the AwDebug reflection interface at a point where WebView (and hence the crash reporter) hasn't been initialized yet. We should just fail in this case. BUG=698243 ========== to ========== aw: Do not DumpWithoutCrashing if crash reporter is not enabled. GSA can apparently use the AwDebug reflection interface at a point where WebView (and hence the crash reporter) hasn't been initialized yet. We should just fail in this case. BUG=698243 ==========
tobiasjs@chromium.org changed reviewers: + torne@chromium.org
lgtm
The CQ bit was checked by tobiasjs@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by tobiasjs@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #4 (id:60001) has been deleted
lgtm
The CQ bit was checked by tobiasjs@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488970487950850,
"parent_rev": "f35783d6563003295d1f78ff87cee60b1c05fd1e", "commit_rev":
"dec2b22c83c792439a84157ee7bc6c900ea89c09"}
Message was sent while issue was closed.
Description was changed from ========== aw: Do not DumpWithoutCrashing if crash reporter is not enabled. GSA can apparently use the AwDebug reflection interface at a point where WebView (and hence the crash reporter) hasn't been initialized yet. We should just fail in this case. BUG=698243 ========== to ========== aw: Do not DumpWithoutCrashing if crash reporter is not enabled. GSA can apparently use the AwDebug reflection interface at a point where WebView (and hence the crash reporter) hasn't been initialized yet. We should just fail in this case. BUG=698243 Review-Url: https://codereview.chromium.org/2729093004 Cr-Commit-Position: refs/heads/master@{#455426} Committed: https://chromium.googlesource.com/chromium/src/+/dec2b22c83c792439a84157ee7bc... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/dec2b22c83c792439a84157ee7bc... |
