base/debug/stack_trace_unittest.cc - Issue 2735113003: Changing SpawnChild to return a struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace_unittest.cc

Issue 2735113003: Changing SpawnChild to return a struct.

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/stack_trace_unittest.cc

diff --git a/base/debug/stack_trace_unittest.cc b/base/debug/stack_trace_unittest.cc

index 560dc1ddde8dc5ee7dd42e62b0e0e296ad5a5ac4..838af54fcd94d2ff5b2bf15bf3fd22cf954636af 100644

--- a/base/debug/stack_trace_unittest.cc

+++ b/base/debug/stack_trace_unittest.cc

@@ -171,7 +171,8 @@ MULTIPROCESS_TEST_MAIN(MismatchedMallocChildProcess) {

// and e.g. mismatched new[]/delete would cause a hang because

// of re-entering malloc.

TEST_F(StackTraceTest, AsyncSignalUnsafeSignalHandlerHang) {

- Process child = SpawnChild("MismatchedMallocChildProcess");

+ SpawnChildResult spawn_result = SpawnChild("MismatchedMallocChildProcess");

+ Process child = std::move(spawn_result.process);

ASSERT_TRUE(child.IsValid());

int exit_code;

ASSERT_TRUE(child.WaitForExitWithTimeout(TestTimeouts::action_timeout(),

« no previous file with comments | « base/android/parcelable_channel_server.cc ('k') | base/files/file_locking_unittest.cc » ('j') | no next file with comments »