Implemented the CSSPropertyAPI for the line-height property.

Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012
Review-Url: https://codereview.chromium.org/2735093005
Cr-Commit-Position: refs/heads/master@{#455961}
Committed: https://chromium.googlesource.com/chromium/src/+/c76129a90d82fa5587bcbabb4f93f9c7ebb23a70

[Bugs Nash, 2017-03-08 00:29:24]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[Bugs Nash, 2017-03-08 00:29:44]

bugsnash@chromium.org changed reviewers:
+ rvera@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:30:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-03-08 00:30:37]

Description was changed from

==========
Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.in, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

BUG=668012
==========

to

==========
Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.in, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012
==========

[Raul Vera, 2017-03-08 00:43:13]

The description mentions a change to CSSProperties.in, which I believe should be
CSSProperties.Json5, no? Or am I missing something?

On 2017/03/08 at 00:30:37, bugsnash wrote:
> Description was changed from
> 
> ==========
> Implemented the CSSPropertyAPI for the line-height property.
> 
> Part of Project Ribbon, separating the parsing logic for CSS
> properties from the parser into an API.
> 
> This patch
> - added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
> - added parseSingleValue method to the CSSPropertyAPILineHeight API
> - removed CSSPropertyLineHeight from the switch
>   statement in parseSingleValue, and calls the API instead.
> - added api implementation details to CSSProperties.in, indicating that
>   CSSPropertyAPILineHeight.h is generated.
> 
> A function pointer to the parseSingleValue function from the API for the
> line-height property is stored in a CSSPropertyDescriptor, and is called
> from CSSPropertyParser.
> 
> BUG=668012
> ==========
> 
> to
> 
> ==========
> Implemented the CSSPropertyAPI for the line-height property.
> 
> Part of Project Ribbon, separating the parsing logic for CSS
> properties from the parser into an API.
> 
> This patch
> - added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
> - added parseSingleValue method to the CSSPropertyAPILineHeight API
> - removed CSSPropertyLineHeight from the switch
>   statement in parseSingleValue, and calls the API instead.
> - added api implementation details to CSSProperties.in, indicating that
>   CSSPropertyAPILineHeight.h is generated.
> 
> A function pointer to the parseSingleValue function from the API for the
> line-height property is stored in a CSSPropertyDescriptor, and is called
> from CSSPropertyParser.
> 
> Originally authored in patch 2642783005 by sashab@chromium.org
> 
> BUG=668012
> ==========

[commit-bot: I haz the power, 2017-03-08 01:28:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:28:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Bugs Nash, 2017-03-08 03:49:38]

Description was changed from

==========
Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.in, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012
==========

to

==========
Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012
==========

[Bugs Nash, 2017-03-08 03:50:19]

On 2017/03/08 at 00:43:13, rvera wrote:
> The description mentions a change to CSSProperties.in, which I believe should
be CSSProperties.Json5, no? Or am I missing something?
> 
> On 2017/03/08 at 00:30:37, bugsnash wrote:
> > Description was changed from
> > 
> > ==========
> > Implemented the CSSPropertyAPI for the line-height property.
> > 
> > Part of Project Ribbon, separating the parsing logic for CSS
> > properties from the parser into an API.
> > 
> > This patch
> > - added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
> > - added parseSingleValue method to the CSSPropertyAPILineHeight API
> > - removed CSSPropertyLineHeight from the switch
> >   statement in parseSingleValue, and calls the API instead.
> > - added api implementation details to CSSProperties.in, indicating that
> >   CSSPropertyAPILineHeight.h is generated.
> > 
> > A function pointer to the parseSingleValue function from the API for the
> > line-height property is stored in a CSSPropertyDescriptor, and is called
> > from CSSPropertyParser.
> > 
> > BUG=668012
> > ==========
> > 
> > to
> > 
> > ==========
> > Implemented the CSSPropertyAPI for the line-height property.
> > 
> > Part of Project Ribbon, separating the parsing logic for CSS
> > properties from the parser into an API.
> > 
> > This patch
> > - added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
> > - added parseSingleValue method to the CSSPropertyAPILineHeight API
> > - removed CSSPropertyLineHeight from the switch
> >   statement in parseSingleValue, and calls the API instead.
> > - added api implementation details to CSSProperties.in, indicating that
> >   CSSPropertyAPILineHeight.h is generated.
> > 
> > A function pointer to the parseSingleValue function from the API for the
> > line-height property is stored in a CSSPropertyDescriptor, and is called
> > from CSSPropertyParser.
> > 
> > Originally authored in patch 2642783005 by sashab@chromium.org
> > 
> > BUG=668012
> > ==========

You are not missing anything, that was a mistake. Thanks for the spot, have
fixed now :)

[Bugs Nash, 2017-03-08 03:58:30]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:58:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 03:58:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:58:58]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Bugs Nash, 2017-03-08 04:28:13]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 04:28:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:29:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:29:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Bugs Nash, 2017-03-08 04:46:09]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 04:46:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 04:49:14]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Raul Vera, 2017-03-08 21:33:53]

lgtm

[Bugs Nash, 2017-03-08 22:29:10]

bugsnash@chromium.org changed reviewers:
+ meade@chromium.org

[Bugs Nash, 2017-03-08 22:29:17]

bugsnash@chromium.org changed reviewers:
- meade@chromium.org

[Bugs Nash, 2017-03-08 22:29:18]

meade@ for owners

[Bugs Nash, 2017-03-08 22:30:30]

bugsnash@chromium.org changed reviewers:
+ meade@chromium.org

[Bugs Nash, 2017-03-08 22:30:31]

meade@ for owners

[meade_UTC10, 2017-03-09 05:51:54]

lgtm

Looks like you need to rebase :/

https://codereview.chromium.org/2735093005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/BUILD.gn (right):

https://codereview.chromium.org/2735093005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/BUILD.gn:538:
"$blink_core_output_dir/css/properties/CSSPropertyAPILineHeight.h",
Same nit - maybe it can be addressed in a later CL, wondering if these should be
alphabetical?

[Bugs Nash, 2017-03-09 21:47:50]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:48:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-03-09 23:10:09]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-03-09 23:10:09]

The patchset sent to the CQ was uploaded after l-g-t-m from rvera@chromium.org,
meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2735093005/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2017-03-09 23:11:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:31:29]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489101009614940,
"parent_rev": "f1182f7fd840ec2911c1b7c433064f69135e1948", "commit_rev":
"c76129a90d82fa5587bcbabb4f93f9c7ebb23a70"}

[commit-bot: I haz the power, 2017-03-10 02:34:14]

Description was changed from

==========
Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012
==========

to

==========
Implemented the CSSPropertyAPI for the line-height property.

Part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API.

This patch
- added CSSPropertyAPILineHeight.cpp, which implements CSSPropertyAPI.h
- added parseSingleValue method to the CSSPropertyAPILineHeight API
- removed CSSPropertyLineHeight from the switch
  statement in parseSingleValue, and calls the API instead.
- added api implementation details to CSSProperties.json5, indicating that
  CSSPropertyAPILineHeight.h is generated.

A function pointer to the parseSingleValue function from the API for the
line-height property is stored in a CSSPropertyDescriptor, and is called
from CSSPropertyParser.

Originally authored in patch 2642783005 by sashab@chromium.org

BUG=668012

Review-Url: https://codereview.chromium.org/2735093005
Cr-Commit-Position: refs/heads/master@{#455961}
Committed:
https://chromium.googlesource.com/chromium/src/+/c76129a90d82fa5587bcbabb4f93...
==========

[commit-bot: I haz the power, 2017-03-10 02:34:15]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c76129a90d82fa5587bcbabb4f93...