Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2731953004: Implemented the CSSPropertyAPI for the font-family property. (Closed)

Created:
3 years, 9 months ago by Bugs Nash
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10, Raul Vera
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implemented the CSSPropertyAPI for the font-family property. Part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch - added CSSPropertyAPIFontFamily.cpp, which implements CSSPropertyAPI.h - added parseSingleValue method to the CSSPropertyAPIFontFamily API - removed CSSPropertyFontFamily from the switch statement in parseSingleValue, and calls the API instead. - added api implementation details to CSSProperties.json5, indicating that CSSPropertyAPIFontFamily.h is generated. A function pointer to the parseSingleValue function from the API for the font-family property is stored in a CSSPropertyDescriptor, and is called from CSSPropertyParser. Originally authored in patch 2641123002 by sashab@chromium.org BUG=668012 Review-Url: https://codereview.chromium.org/2731953004 Cr-Commit-Position: refs/heads/master@{#455988} Committed: https://chromium.googlesource.com/chromium/src/+/b1575e90e984d8aea66570d07b7126034e9a7b8c

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFontFamily.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (19 generated)
Bugs Nash
3 years, 9 months ago (2017-03-08 05:36:02 UTC) #4
Raul Vera
lgtm
3 years, 9 months ago (2017-03-08 21:55:32 UTC) #7
Bugs Nash
meade@ for owners
3 years, 9 months ago (2017-03-08 22:28:54 UTC) #10
Bugs Nash
meade@ for owners
3 years, 9 months ago (2017-03-08 22:30:19 UTC) #12
meade_UTC10
lgtm https://codereview.chromium.org/2731953004/diff/1/third_party/WebKit/Source/core/BUILD.gn File third_party/WebKit/Source/core/BUILD.gn (right): https://codereview.chromium.org/2731953004/diff/1/third_party/WebKit/Source/core/BUILD.gn#newcode538 third_party/WebKit/Source/core/BUILD.gn:538: "$blink_core_output_dir/css/properties/CSSPropertyAPIFontFamily.h", Nit: should these be in alphabetical order?
3 years, 9 months ago (2017-03-09 05:48:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731953004/1
3 years, 9 months ago (2017-03-09 20:53:18 UTC) #15
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-09 22:51:31 UTC) #17
commit-bot: I haz the power
This CL has an open dependency (Issue 2735093005 Patch 60001). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-10 01:10:11 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2731953004/20001
3 years, 9 months ago (2017-03-10 03:56:38 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 04:14:11 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1575e90e984d8aea66570d07b71...

Powered by Google App Engine
This is Rietveld 408576698