Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2734983003:
remove DCHECK for resourceless software allowing more than one render pass. (Closed)
|
Created:
3 years, 9 months ago by Shimi Zhang Modified:
3 years, 9 months ago Reviewers:
danakj CC:
chromium-reviews, cc-bugs_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionremove DCHECK for resourceless software allowing more than one render pass.
BUG=697976
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2734983003
Cr-Commit-Position: refs/heads/master@{#455127}
Committed: https://chromium.googlesource.com/chromium/src/+/7647683e57f52c2dd80d14e9475df3763a226b64
Patch Set 1 #
Messages
Total messages: 25 (21 generated)
Description was changed from ========== remove DCHECK for resourceless software allowing more than one render pass. BUG=697976 ========== to ========== remove DCHECK for resourceless software allowing more than one render pass. BUG=697976 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ctzsm@chromium.org changed reviewers: + danakj@chromium.org
Please review, Thanks.
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by ctzsm@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ctzsm@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488908744683450, "parent_rev":
"cfd3fb474d3d26674c5e1329d5db953ea2be3ee5", "commit_rev":
"7647683e57f52c2dd80d14e9475df3763a226b64"}
Message was sent while issue was closed.
Description was changed from ========== remove DCHECK for resourceless software allowing more than one render pass. BUG=697976 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== remove DCHECK for resourceless software allowing more than one render pass. BUG=697976 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2734983003 Cr-Commit-Position: refs/heads/master@{#455127} Committed: https://chromium.googlesource.com/chromium/src/+/7647683e57f52c2dd80d14e9475d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7647683e57f52c2dd80d14e9475d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
