Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: cc/trees/layer_tree_host_impl.cc

Issue 2734983003: remove DCHECK for resourceless software allowing more than one render pass. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host_impl.h" 5 #include "cc/trees/layer_tree_host_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1002 matching lines...) Expand 10 before | Expand all | Expand 10 after
1013 UMA_HISTOGRAM_COUNTS( 1013 UMA_HISTOGRAM_COUNTS(
1014 "Compositing.RenderPass.AppendQuadData." 1014 "Compositing.RenderPass.AppendQuadData."
1015 "CheckerboardedNoRecordingContentArea", 1015 "CheckerboardedNoRecordingContentArea",
1016 checkerboarded_no_recording_content_area); 1016 checkerboarded_no_recording_content_area);
1017 UMA_HISTOGRAM_COUNTS( 1017 UMA_HISTOGRAM_COUNTS(
1018 "Compositing.RenderPass.AppendQuadData." 1018 "Compositing.RenderPass.AppendQuadData."
1019 "CheckerboardedNeedRasterContentArea", 1019 "CheckerboardedNeedRasterContentArea",
1020 checkerboarded_needs_raster_content_area); 1020 checkerboarded_needs_raster_content_area);
1021 } 1021 }
1022 1022
1023 // Should only have one render pass in resourceless software mode.
1024 DCHECK(draw_mode != DRAW_MODE_RESOURCELESS_SOFTWARE ||
1025 frame->render_passes.size() == 1u)
1026 << frame->render_passes.size();
1027
1028 TRACE_EVENT_END2("cc", "LayerTreeHostImpl::CalculateRenderPasses", 1023 TRACE_EVENT_END2("cc", "LayerTreeHostImpl::CalculateRenderPasses",
1029 "draw_result", draw_result, "missing tiles", 1024 "draw_result", draw_result, "missing tiles",
1030 num_missing_tiles); 1025 num_missing_tiles);
1031 1026
1032 // Draw has to be successful to not drop the copy request layer. 1027 // Draw has to be successful to not drop the copy request layer.
1033 // When we have a copy request for a layer, we need to draw even if there 1028 // When we have a copy request for a layer, we need to draw even if there
1034 // would be animating checkerboards, because failing under those conditions 1029 // would be animating checkerboards, because failing under those conditions
1035 // triggers a new main frame, which may cause the copy request layer to be 1030 // triggers a new main frame, which may cause the copy request layer to be
1036 // destroyed. 1031 // destroyed.
1037 // TODO(weiliangc): Test copy request w/ CompositorFrameSink recreation. Would 1032 // TODO(weiliangc): Test copy request w/ CompositorFrameSink recreation. Would
(...skipping 3122 matching lines...) Expand 10 before | Expand all | Expand 10 after
4160 worker_context_visibility_ = 4155 worker_context_visibility_ =
4161 worker_context->CacheController()->ClientBecameVisible(); 4156 worker_context->CacheController()->ClientBecameVisible();
4162 } else { 4157 } else {
4163 worker_context->CacheController()->ClientBecameNotVisible( 4158 worker_context->CacheController()->ClientBecameNotVisible(
4164 std::move(worker_context_visibility_)); 4159 std::move(worker_context_visibility_));
4165 } 4160 }
4166 } 4161 }
4167 } 4162 }
4168 4163
4169 } // namespace cc 4164 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698