Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2734913002: Skip page refresh navigation in navigation observer (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Skip page refresh navigation in navigation observer Since page refresh navigations have the same source and destination url, and do not help us attribute downloads, we can safely skip them (and save the quota for other meaningful navigations). BUG=698121 Review-Url: https://codereview.chromium.org/2728123003 Cr-Commit-Position: refs/heads/master@{#454658} (cherry picked from commit 0a5231e4ca6ec1af9908e4b35590da1cdf4918fa) Review-Url: https://codereview.chromium.org/2734913002 . Cr-Commit-Position: refs/branch-heads/2987@{#771} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/f9336d16c03b81831b6e547a005a3dfd06b65450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Jialiu Lin
3 years, 9 months ago (2017-03-06 18:45:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f9336d16c03b81831b6e547a005a3dfd06b65450.

Powered by Google App Engine
This is Rietveld 408576698