Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 2728123003: Skip page refresh navigation in navigation observer (Closed)

Created:
3 years, 9 months ago by Jialiu Lin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip page refresh navigation in navigation observer Since page refresh navigations have the same source and destination url, and do not help us attribute downloads, we can safely skip them (and save the quota for other meaningful navigations). BUG=698121 Review-Url: https://codereview.chromium.org/2728123003 Cr-Commit-Position: refs/heads/master@{#454658} Committed: https://chromium.googlesource.com/chromium/src/+/0a5231e4ca6ec1af9908e4b35590da1cdf4918fa

Patch Set 1 : skip page refresh navigation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Jialiu Lin
vakh@, Could you take a look at this tiny CL? Thanks!
3 years, 9 months ago (2017-03-03 19:14:07 UTC) #5
vakh (use Gerrit instead)
lgtm
3 years, 9 months ago (2017-03-03 19:15:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728123003/20001
3 years, 9 months ago (2017-03-03 20:05:17 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 20:12:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a5231e4ca6ec1af9908e4b35590...

Powered by Google App Engine
This is Rietveld 408576698