Expand FrameSelection::isInPasswordFiled() into call sites

Expand FrameSelection::isInPasswordFiled() into call sites

This patch expands |FrameSelection::isInPasswordFiled()| into call sites to
avoid to use |computeVisibleSelectionInDOMTreeDeprecated()| for improving code
health.

BUG=698633
TEST=n/a

Review-Url: https://codereview.chromium.org/2734793002
Cr-Commit-Position: refs/heads/master@{#455417}
Committed: https://chromium.googlesource.com/chromium/src/+/a2d360523e94ba92514d45cb9d260c0c3364e5a5

[yosin_UTC9, 2017-03-06 06:52:52]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-03-06 06:53:21]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 06:53:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 08:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 08:44:09]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-07 02:25:22]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 02:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-07 05:07:36]

Description was changed from

==========
2017-03-06T15:50:23

2017-03-06T15:49:20

BUG=
==========

to

==========
Expand FrameSelection::isInPasswordFiled() into call sites

This patch expands |FrameSelection::isInPasswordFiled()| into call sites to
avoid to use |computeVisibleSelectionInDOMTreeDeprecated()| for improving code
health.

BUG=698633
TEST=n/a
==========

[yosin_UTC9, 2017-03-07 05:08:32]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-07 05:08:32]

PTAL

Win bots failures are not related this patch. They failed on test_installer.

[commit-bot: I haz the power, 2017-03-07 05:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:21:51]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yoichio, 2017-03-07 05:31:15]

lgtm

[tkent, 2017-03-07 05:39:57]

lgtm, however selection normalization doesn't cross over editing boundaries, and
selectionInDOMTree().start() is always ok for isInPasswordField(), right?

[yosin_UTC9, 2017-03-07 05:43:41]

On 2017/03/07 at 05:39:57, tkent wrote:
> lgtm, however selection normalization doesn't cross over editing boundaries,
and selectionInDOMTree().start() is always ok for isInPasswordField(), right?

Yes, selection can cross editing boundaries, at this time, user-selection CSS
property make selection crossing editing/shadow boundaries.

[yosin_UTC9, 2017-03-07 05:43:45]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 05:44:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-07 06:05:58]

> > lgtm, however selection normalization doesn't cross over editing boundaries,
and selectionInDOMTree().start() is always ok for isInPasswordField(), right?
> 
> Yes, selection can cross editing boundaries, at this time, user-selection CSS
property make selection crossing editing/shadow boundaries.

I didn't talk about whether selection can cross or not.  Can a Position inside a
text control element be normalized to another Position outside of the text
control?

[commit-bot: I haz the power, 2017-03-07 07:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:39:23]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2017-03-07 07:58:52]

On 2017/03/07 at 06:05:58, tkent wrote:
> > > lgtm, however selection normalization doesn't cross over editing
boundaries, and selectionInDOMTree().start() is always ok for
isInPasswordField(), right?
> > 
> > Yes, selection can cross editing boundaries, at this time, user-selection
CSS property make selection crossing editing/shadow boundaries.
> 
> I didn't talk about whether selection can cross or not.  

Sorry for confusion.

> Can a Position inside a text control element be normalized to another Position
outside of the text control?
No. Normalization does not move position in text control outside text control.
Once we have user-select:contain. We should have input[type=text]: user-select:
content !important

[yosin_UTC9, 2017-03-07 07:59:08]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:59:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 09:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:10:49]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2017-03-07 14:37:14]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:37:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:39:30]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yosin_UTC9, 2017-03-08 00:58:30]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-08 00:59:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:35:28]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[yosin_UTC9, 2017-03-08 05:34:08]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-08 05:34:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 06:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 06:26:40]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2017-03-08 07:29:05]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-08 07:29:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 09:38:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488958145652830,
"parent_rev": "196a572ea1ff4a260f80bb3f96ebd4ffeaed0f71", "commit_rev":
"a2d360523e94ba92514d45cb9d260c0c3364e5a5"}

[commit-bot: I haz the power, 2017-03-08 09:39:06]

Description was changed from

==========
Expand FrameSelection::isInPasswordFiled() into call sites

This patch expands |FrameSelection::isInPasswordFiled()| into call sites to
avoid to use |computeVisibleSelectionInDOMTreeDeprecated()| for improving code
health.

BUG=698633
TEST=n/a
==========

to

==========
Expand FrameSelection::isInPasswordFiled() into call sites

This patch expands |FrameSelection::isInPasswordFiled()| into call sites to
avoid to use |computeVisibleSelectionInDOMTreeDeprecated()| for improving code
health.

BUG=698633
TEST=n/a

Review-Url: https://codereview.chromium.org/2734793002
Cr-Commit-Position: refs/heads/master@{#455417}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2d360523e94ba92514d45cb9d26...
==========

[commit-bot: I haz the power, 2017-03-08 09:39:07]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a2d360523e94ba92514d45cb9d26...