Expand FrameSelection::isInPasswordFiled() into call sites

third_party/WebKit/Source/core/input/MouseEventManager.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/input/MouseEventManager.h"
 
 #include "core/clipboard/DataObject.h"
 #include "core/clipboard/DataTransfer.h"
 #include "core/dom/Element.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/TaskRunnerHelper.h"
+#include "core/editing/EditingUtilities.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/SelectionController.h"
 #include "core/events/DragEvent.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Settings.h"
 #include "core/html/HTMLCanvasElement.h"
 #include "core/input/EventHandler.h"
 #include "core/input/EventHandlingUtil.h"
@@ skipping 818 matching lines @@
   if (!dragController.populateDragDataTransfer(m_frame, dragState(),
                                                m_mouseDownPos))
     return false;
 
   // If dispatching dragstart brings about another mouse down -- one way
   // this will happen is if a DevTools user breaks within a dragstart
   // handler and then clicks on the suspended page -- the drag state is
   // reset. Hence, need to check if this particular drag operation can
   // continue even if dispatchEvent() indicates no (direct) cancellation.
   // Do that by checking if m_dragSrc is still set.
-  m_mouseDownMayStartDrag =
-      dispatchDragSrcEvent(EventTypeNames::dragstart, m_mouseDown) ==
+  m_mouseDownMayStartDrag = false;
+  if (dispatchDragSrcEvent(EventTypeNames::dragstart, m_mouseDown) ==
           WebInputEventResult::NotHandled &&
-      !m_frame->selection().isInPasswordField() && dragState().m_dragSrc;
+      dragState().m_dragSrc) {
+    // TODO(editing-dev): The use of
+    // updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.  See
+    // http://crbug.com/590369 for more details.
+    m_frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+    m_mouseDownMayStartDrag = !isInPasswordField(
+        m_frame->selection().computeVisibleSelectionInDOMTree().start());
+  }
 
   // Invalidate clipboard here against anymore pasteboard writing for security.
   // The drag image can still be changed as we drag, but not the pasteboard
   // data.
   dragState().m_dragDataTransfer->setAccessPolicy(DataTransferImageWritable);
 
   if (m_mouseDownMayStartDrag) {
     // Dispatching the event could cause Page to go away. Make sure it's still
     // valid before trying to use DragController.
     if (m_frame->page() &&
@@ skipping 147 matching lines @@
 
 void MouseEventManager::setClickCount(int clickCount) {
   m_clickCount = clickCount;
 }
 
 bool MouseEventManager::mouseDownMayStartDrag() {
   return m_mouseDownMayStartDrag;
 }
 
 }  // namespace blink