Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2734763002: Add VisibleUnits::endfWordPosition (Closed)

Created:
3 years, 9 months ago by yoichio
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add VisibleUnits::endfWordPosition This is Position version of |endOfWord| which returns VisiblePosition. Since returned Position should be already canonicalized with |nextBoundary()|, we can replace them. TEST=No change in behavior. BUG=697725 Review-Url: https://codereview.chromium.org/2734763002 Cr-Commit-Position: refs/heads/master@{#454836} Committed: https://chromium.googlesource.com/chromium/src/+/64a4419d59615578571e7cfd50237f489a7ec7bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.h View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +19 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yoichio
3 years, 9 months ago (2017-03-06 06:47:55 UTC) #8
yosin_UTC9
lgtm
3 years, 9 months ago (2017-03-06 06:51:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734763002/1
3 years, 9 months ago (2017-03-06 06:51:13 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 06:56:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/64a4419d59615578571e7cfd5023...

Powered by Google App Engine
This is Rietveld 408576698