Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnits.cpp

Issue 2734763002: Add VisibleUnits::endfWordPosition (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleUnits.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
index 32c5d1c721fa34081095cb639873345264e04e56..a224931c34b15cb4c2b709fd65a38ff2d9a6d2c6 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
@@ -1090,33 +1090,43 @@ static unsigned endWordBoundary(
}
template <typename Strategy>
-static VisiblePositionTemplate<Strategy> endOfWordAlgorithm(
+static PositionTemplate<Strategy> endOfWordAlgorithm(
const VisiblePositionTemplate<Strategy>& c,
EWordSide side) {
DCHECK(c.isValid()) << c;
VisiblePositionTemplate<Strategy> p = c;
if (side == LeftWordIfOnBoundary) {
if (isStartOfParagraph(c))
- return c;
+ return c.deepEquivalent();
p = previousPositionOf(c);
if (p.isNull())
- return c;
+ return c.deepEquivalent();
} else if (isEndOfParagraph(c)) {
- return c;
+ return c.deepEquivalent();
}
- return createVisiblePosition(nextBoundary(p, endWordBoundary),
+ return nextBoundary(p, endWordBoundary);
+}
+
+Position endOfWordPosition(const VisiblePosition& position, EWordSide side) {
+ return endOfWordAlgorithm<EditingStrategy>(position, side);
+}
+
+VisiblePosition endOfWord(const VisiblePosition& position, EWordSide side) {
+ return createVisiblePosition(endOfWordPosition(position, side),
VP_UPSTREAM_IF_POSSIBLE);
}
-VisiblePosition endOfWord(const VisiblePosition& c, EWordSide side) {
- return endOfWordAlgorithm<EditingStrategy>(c, side);
+PositionInFlatTree endOfWordPosition(const VisiblePositionInFlatTree& position,
+ EWordSide side) {
+ return endOfWordAlgorithm<EditingInFlatTreeStrategy>(position, side);
}
-VisiblePositionInFlatTree endOfWord(const VisiblePositionInFlatTree& c,
+VisiblePositionInFlatTree endOfWord(const VisiblePositionInFlatTree& position,
EWordSide side) {
- return endOfWordAlgorithm<EditingInFlatTreeStrategy>(c, side);
+ return createVisiblePosition(endOfWordPosition(position, side),
+ VP_UPSTREAM_IF_POSSIBLE);
}
static unsigned previousWordPositionBoundary(
« no previous file with comments | « third_party/WebKit/Source/core/editing/VisibleUnits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698