RELAND: ShapeDetection: add support for Text Detection in Mac

RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer
(1st spotted in https://codereview.chromium.org/2726843006/#msg29)
This CL adds forward-declaration of this class before 10.11.

Incidentally, it's the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24


Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium  --enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=avi@chromium.org, rsesek@chromium.org since it's a trivial fwd-declaration.

Review-Url: https://codereview.chromium.org/2734703002
Cr-Commit-Position: refs/heads/master@{#454816}
Committed: https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce49485a746b379

[mcasas, 2017-03-05 06:07:42]

Description was changed from

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer

Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
==========

to

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer

Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-05 06:11:56]

Description was changed from

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer

Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer

(spotted in https://codereview.chromium.org/2726843006/#msg29)

Which is the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24

This CL adds forward-declaration of this class before 10.11.

Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-05 06:13:13]

Description was changed from

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer

(spotted in https://codereview.chromium.org/2726843006/#msg29)

Which is the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24

This CL adds forward-declaration of this class before 10.11.

Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer
(1st spotted in https://codereview.chromium.org/2726843006/#msg29)
This CL adds forward-declaration of this class before 10.11.

Incidentally, it's the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24


Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-03-05 06:46:01]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-03-05 06:46:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-05 06:46:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 06:46:07]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[mcasas, 2017-03-05 06:46:07]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-03-05 06:50:23]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-05 06:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-05 07:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-05 07:52:36]

Dry run: This issue passed the CQ dry run.

[mcasas, 2017-03-06 02:54:36]

Description was changed from

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer
(1st spotted in https://codereview.chromium.org/2726843006/#msg29)
This CL adds forward-declaration of this class before 10.11.

Incidentally, it's the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24


Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer
(1st spotted in https://codereview.chromium.org/2726843006/#msg29)
This CL adds forward-declaration of this class before 10.11.

Incidentally, it's the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24


Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=avi@chromium.org, rsesek@chromium.org since it's a trivial fwd-declaration.
==========

[mcasas, 2017-03-06 02:54:43]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-03-06 02:55:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 02:58:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488768883814410,
"parent_rev": "1504af7fee3fcc0532208cfe3042571d89d131ed", "commit_rev":
"9eba8ffcc405012f235a5bfb5ce49485a746b379"}

[commit-bot: I haz the power, 2017-03-06 02:59:32]

Description was changed from

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer
(1st spotted in https://codereview.chromium.org/2726843006/#msg29)
This CL adds forward-declaration of this class before 10.11.

Incidentally, it's the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24


Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=avi@chromium.org, rsesek@chromium.org since it's a trivial fwd-declaration.
==========

to

==========
RELAND: ShapeDetection: add support for Text Detection in Mac

The original CL got reverted due to out-of-bots partial availability
warnings such as :
../../services/shape_detection/text_detection_impl_mac.mm:68:8:
> error: 'CIRectangleFeature' is only available on macOS 10_10 or newer
(1st spotted in https://codereview.chromium.org/2726843006/#msg29)
This CL adds forward-declaration of this class before 10.11.

Incidentally, it's the same issue addressed in e.g. 
https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24


Original issue's description:
> ShapeDetection: add support for Text Detection in Mac
>
> This CL adds text detection for Mac in services/shape_detection,
> and also adds unittest for it, that will be run, like the
> other specific unittests, in the mac gpu bots.
>
> BUG=697925
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> TEST= unittests that can be run anywhere like this:
> out/gn/service_unittests  --gtest_filter=*TextDetection* --use-gpu-in-tests
>
> and demo page, e.g.
> ./out/gn/Chromium.app/Contents/MacOS/Chromium 
--enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg
>
> Review-Url: https://codereview.chromium.org/2726843006
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

TBR=avi@chromium.org, rsesek@chromium.org since it's a trivial fwd-declaration.

Review-Url: https://codereview.chromium.org/2734703002
Cr-Commit-Position: refs/heads/master@{#454816}
Committed:
https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce4...
==========

[commit-bot: I haz the power, 2017-03-06 02:59:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce4...