Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2734703002: RELAND: ShapeDetection: add support for Text Detection in Mac (Closed)

Created:
3 years, 1 month ago by mcasas
Modified:
3 years, 1 month ago
Reviewers:
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mac-reviews_chromium.org, darin (slow to review), viettrungluu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RELAND: ShapeDetection: add support for Text Detection in Mac The original CL got reverted due to out-of-bots partial availability warnings such as : ../../services/shape_detection/text_detection_impl_mac.mm:68:8: > error: 'CIRectangleFeature' is only available on macOS 10_10 or newer (1st spotted in https://codereview.chromium.org/2726843006/#msg29) This CL adds forward-declaration of this class before 10.11. Incidentally, it's the same issue addressed in e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24 Original issue's description: > ShapeDetection: add support for Text Detection in Mac > > This CL adds text detection for Mac in services/shape_detection, > and also adds unittest for it, that will be run, like the > other specific unittests, in the mac gpu bots. > > BUG=697925 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > TEST= unittests that can be run anywhere like this: > out/gn/service_unittests --gtest_filter=*TextDetection* --use-gpu-in-tests > > and demo page, e.g. > ./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg > > Review-Url: https://codereview.chromium.org/2726843006 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=avi@chromium.org, rsesek@chromium.org since it's a trivial fwd-declaration. Review-Url: https://codereview.chromium.org/2734703002 Cr-Commit-Position: refs/heads/master@{#454816} Committed: https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce49485a746b379

Patch Set 1 : Verbatim https://codereview.chromium.org/2726843006/ #

Patch Set 2 : Forward-declare CIRectangleFeature to avoid partial availability warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -2 lines) Patch
M base/mac/sdk_forward_declarations.h View 1 2 chunks +18 lines, -0 lines 0 comments Download
M base/mac/sdk_forward_declarations.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shape_detection/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
M services/shape_detection/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M services/shape_detection/shape_detection_service.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A services/shape_detection/text_detection_impl.h View 1 chunk +24 lines, -0 lines 0 comments Download
A services/shape_detection/text_detection_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
A services/shape_detection/text_detection_impl_mac.h View 1 chunk +33 lines, -0 lines 0 comments Download
A services/shape_detection/text_detection_impl_mac.mm View 1 chunk +83 lines, -0 lines 0 comments Download
A services/shape_detection/text_detection_impl_mac_unittest.mm View 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734703002/20001
3 years, 1 month ago (2017-03-05 06:46:05 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 1 month ago (2017-03-05 06:46:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734703002/20001
3 years, 1 month ago (2017-03-06 02:55:01 UTC) #15
commit-bot: I haz the power
3 years, 1 month ago (2017-03-06 02:59:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9eba8ffcc405012f235a5bfb5ce4...

Powered by Google App Engine
This is Rietveld 408576698