Chromium Code Reviews
DescriptionDon't look up font size preferences on Android.
These are not configurable on Android so we should rely on the default
value on the WebPreferences object. The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.
Detailed rationale:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236. Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no
other sources for the pref anyway, and the WebPreferences struct has its own
default, which matches what's in the GRD file on other platforms. Because this is
for 56 cherry-pick and the resource ID situation is not yet fully understood, this
seems like a safer fix than, for instance, trying to add a new resource to the
Android GRD file.
BUG=696364
Review-Url: https://codereview.chromium.org/2724203003
Cr-Commit-Position: refs/heads/master@{#454437}
(cherry picked from commit 0df335a1ea5a09d4860168bc05bbf0d11e802bf5)
Review-Url: https://codereview.chromium.org/2734573002 .
Cr-Commit-Position: refs/branch-heads/2924@{#939}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}
Committed: https://chromium.googlesource.com/chromium/src/+/83e5576bf385f4bfd919c7f20d641c05ec13be32
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||