Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2734573002: Don't look up font size preferences on Android. (Closed)

Created:
3 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Don't look up font size preferences on Android. These are not configurable on Android so we should rely on the default value on the WebPreferences object. The use of the unnecessary pref appears to have caused the value to be reused from an unrelated pref when the resource ID space changed. Detailed rationale: * The default value for the font size preference is coming from a resource. * That resource isn't defined on Android, only on all desktop platforms. * This nevertheless used to work for some reason, but that changed with the resource ID reshuffle http://crrev.com/427236. Why precisely this used to work and why it's now broken is not yet fully understood. * This CL fixes this by removing the pref completely, given that there are no other sources for the pref anyway, and the WebPreferences struct has its own default, which matches what's in the GRD file on other platforms. Because this is for 56 cherry-pick and the resource ID situation is not yet fully understood, this seems like a safer fix than, for instance, trying to add a new resource to the Android GRD file. BUG=696364 Review-Url: https://codereview.chromium.org/2724203003 Cr-Commit-Position: refs/heads/master@{#454437} (cherry picked from commit 0df335a1ea5a09d4860168bc05bbf0d11e802bf5) Review-Url: https://codereview.chromium.org/2734573002 . Cr-Commit-Position: refs/branch-heads/2924@{#939} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/83e5576bf385f4bfd919c7f20d641c05ec13be32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
3 years, 9 months ago (2017-03-03 21:47:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83e5576bf385f4bfd919c7f20d641c05ec13be32.

Powered by Google App Engine
This is Rietveld 408576698