Don't look up font size preferences on Android.

Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Detailed rationale:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this is
for 56 cherry-pick and the resource ID situation is not yet fully understood, this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
Review-Url: https://codereview.chromium.org/2724203003
Cr-Commit-Position: refs/heads/master@{#454437}
Committed: https://chromium.googlesource.com/chromium/src/+/0df335a1ea5a09d4860168bc05bbf0d11e802bf5

[aelias_OOO_until_Jul13, 2017-03-02 02:44:08]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 02:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-03-02 02:47:43]

aelias@chromium.org changed reviewers:
+ bauerb@chromium.org

[aelias_OOO_until_Jul13, 2017-03-02 02:49:34]

Hi bauerb@, I thought you might be able to sanity check this since you reviewed
related change https://codereview.chromium.org/27527003 .  If this looks sane,
I'll add additional OWNERS.

[commit-bot: I haz the power, 2017-03-02 05:01:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 05:01:36]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Bernhard Bauer, 2017-03-02 16:35:14]

On 2017/03/02 02:49:34, aelias wrote:
> Hi bauerb@, I thought you might be able to sanity check this since you
reviewed
> related change https://codereview.chromium.org/27527003 .  If this looks sane,
> I'll add additional OWNERS.

The change itself looks good, but I'm not sure I fully understand how the bug
happened. Is this correct?
* The default value for the font size preference is coming from a resource (for
whatever reason)
* That resource isn't actually defined on Android (at least I can't find
anything on codesearch:
https://cs.chromium.org/search/?q=IDS_DEFAULT_FONT_SIZE&sq=package:chromium&t...)
* It nevertheless used to work for some reason, but that changed with the
resource ID reshuffle
* Your CL fixes this by removing the pref completely, given that there are no
other sources for the pref anyway, and the WebPreferences struct has its own
default, which happens to match what's in the GRD file.

If all of that is true, it would be nice to expand the CL description a bit to
explain that whole chain, and in particular it's not the pref ID that changed
but the resource ID, but otherwise LGTM.

[aelias_OOO_until_Jul13, 2017-03-02 22:39:45]

Description was changed from

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the pref ID space changed.

BUG=696364
==========

to

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.



BUG=696364
==========

[aelias_OOO_until_Jul13, 2017-03-02 22:40:34]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 22:41:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-03-02 22:46:20]

Description was changed from

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.



BUG=696364
==========

to

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Rationale as currently understood:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no
other sources for the pref anyway, and the WebPreferences struct has its own
default, which matches what's in the GRD file on other platforms.  Because this
is for 56 cherry-pick and the resource ID situation is not yet fully understood,
this seems like a safer fix than, for instance, trying to add a new resource to
the Android GRD file.

BUG=696364
==========

[aelias_OOO_until_Jul13, 2017-03-02 22:46:43]

Description was changed from

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Rationale as currently understood:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no
other sources for the pref anyway, and the WebPreferences struct has its own
default, which matches what's in the GRD file on other platforms.  Because this
is for 56 cherry-pick and the resource ID situation is not yet fully understood,
this seems like a safer fix than, for instance, trying to add a new resource to
the Android GRD file.

BUG=696364
==========

to

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Rationale as currently understood:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
==========

[aelias_OOO_until_Jul13, 2017-03-02 22:46:53]

Description was changed from

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Rationale as currently understood:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
==========

to

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Rationale as currently understood:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
==========

[aelias_OOO_until_Jul13, 2017-03-02 22:47:14]

Description was changed from

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Rationale as currently understood:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
==========

to

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Detailed rationale:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
==========

[aelias_OOO_until_Jul13, 2017-03-02 22:48:25]

aelias@chromium.org changed reviewers:
+ sky@chromium.org

[aelias_OOO_until_Jul13, 2017-03-02 22:49:09]

I expanded CL description and fixed a unit test.

+sky@ for OWNERS review as thestig@ is OOO and we are planning to respin 56 with
this.

[sky, 2017-03-02 23:22:28]

LGTM

[commit-bot: I haz the power, 2017-03-02 23:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 23:30:16]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-03-02 23:32:31]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-03-02 23:32:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2724203003/#ps20001
(title: "Fix unit test")

[commit-bot: I haz the power, 2017-03-02 23:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 23:43:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488497551755640,
"parent_rev": "a60f7adbae97c275555ab8ff70aa7484c3e9dacd", "commit_rev":
"0df335a1ea5a09d4860168bc05bbf0d11e802bf5"}

[commit-bot: I haz the power, 2017-03-02 23:44:37]

Description was changed from

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Detailed rationale:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364
==========

to

==========
Don't look up font size preferences on Android.

These are not configurable on Android so we should rely on the default
value on the WebPreferences object.  The use of the unnecessary pref
appears to have caused the value to be reused from an unrelated pref
when the resource ID space changed.

Detailed rationale:
* The default value for the font size preference is coming from a resource.
* That resource isn't defined on Android, only on all desktop platforms.
* This nevertheless used to work for some reason, but that changed with the
resource ID reshuffle http://crrev.com/427236.  Why precisely this used to work
and why it's now broken is not yet fully understood.
* This CL fixes this by removing the pref completely, given that there are no 
other sources for the pref anyway, and the WebPreferences struct has its own 
default, which matches what's in the GRD file on other platforms.  Because this
is
for 56 cherry-pick and the resource ID situation is not yet fully understood,
this
seems like a safer fix than, for instance, trying to add a new resource to the 
Android GRD file.

BUG=696364

Review-Url: https://codereview.chromium.org/2724203003
Cr-Commit-Position: refs/heads/master@{#454437}
Committed:
https://chromium.googlesource.com/chromium/src/+/0df335a1ea5a09d4860168bc05bb...
==========

[commit-bot: I haz the power, 2017-03-02 23:44:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0df335a1ea5a09d4860168bc05bb...