Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2734503002: Fully disable LayerTreeHostScrollTestImplSideInvalidation due to crashes (Closed)

Created:
3 years, 9 months ago by pdr.
Modified:
3 years, 9 months ago
Reviewers:
danakj
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fully disable LayerTreeHostScrollTestImplSideInvalidation due to crashes This test is flaky on all platforms. This patch temporarily disables it until a fix is found. This test crashes on OSX with: ./out/Debug/cc_unittests --gtest_filter=LayerTreeHostScrollTestImplSideInvalidation.RunMultiThread_DelegatingRenderer --gtest_repeat=10 BUG=697652 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2734503002 Cr-Commit-Position: refs/heads/master@{#454657} Committed: https://chromium.googlesource.com/chromium/src/+/b02a7c1ab2ee8695d2ac3aeb43bd0ff0fc871ccf

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M cc/trees/layer_tree_host_unittest_scroll.cc View 4 chunks +5 lines, -14 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
pdr.
3 years, 9 months ago (2017-03-03 19:52:10 UTC) #3
danakj
LGTM https://codereview.chromium.org/2734503002/diff/1/cc/trees/layer_tree_host_unittest_scroll.cc File cc/trees/layer_tree_host_unittest_scroll.cc (right): https://codereview.chromium.org/2734503002/diff/1/cc/trees/layer_tree_host_unittest_scroll.cc#newcode2243 cc/trees/layer_tree_host_unittest_scroll.cc:2243: MULTI_THREAD_TEST_F(DISABLED_LayerTreeHostScrollTestImplSideInvalidation); optionally u can just comment out this ...
3 years, 9 months ago (2017-03-03 19:53:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734503002/1
3 years, 9 months ago (2017-03-03 19:53:23 UTC) #6
pdr.
On 2017/03/03 at 19:53:01, danakj wrote: > LGTM > > https://codereview.chromium.org/2734503002/diff/1/cc/trees/layer_tree_host_unittest_scroll.cc > File cc/trees/layer_tree_host_unittest_scroll.cc (right): ...
3 years, 9 months ago (2017-03-03 19:54:33 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 20:07:53 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b02a7c1ab2ee8695d2ac3aeb43bd...

Powered by Google App Engine
This is Rietveld 408576698