Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2381)

Unified Diff: cc/trees/layer_tree_host_unittest_scroll.cc

Issue 2734503002: Fully disable LayerTreeHostScrollTestImplSideInvalidation due to crashes (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_scroll.cc
diff --git a/cc/trees/layer_tree_host_unittest_scroll.cc b/cc/trees/layer_tree_host_unittest_scroll.cc
index 040cf694d68882aa684fc2ea26a319471c9f72a2..93c4856f3c090ca72f9d0b4a759dd9881c528e13 100644
--- a/cc/trees/layer_tree_host_unittest_scroll.cc
+++ b/cc/trees/layer_tree_host_unittest_scroll.cc
@@ -9,7 +9,6 @@
#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
#include "base/threading/thread_task_runner_handle.h"
-#include "build/build_config.h"
#include "cc/animation/animation_host.h"
#include "cc/base/completion_event.h"
#include "cc/input/main_thread_scrolling_reason.h"
@@ -2072,20 +2071,12 @@ class LayerTreeHostScrollTestPropertyTreeUpdate
SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostScrollTestPropertyTreeUpdate);
-// Disabled due to flakes/crashes on Linux TSan Tests, linux_chromium_asan_rel
-// and Android N5X Swarm; see https://crbug.com/697652.
-#if defined(OS_LINUX) || defined(OS_ANDROID)
-#define MAYBE_LayerTreeHostScrollTestImplSideInvalidation \
- DISABLED_LayerTreeHostScrollTestImplSideInvalidation
-#else
-#define MAYBE_LayerTreeHostScrollTestImplSideInvalidation \
- LayerTreeHostScrollTestImplSideInvalidation
-#endif
-class MAYBE_LayerTreeHostScrollTestImplSideInvalidation
+// Disabled due to flakes/crashes, see https://crbug.com/697652.
+class DISABLED_LayerTreeHostScrollTestImplSideInvalidation
: public LayerTreeHostScrollTest {
void BeginTest() override {
layer_tree_host()->outer_viewport_scroll_layer()->set_did_scroll_callback(
- base::Bind(&MAYBE_LayerTreeHostScrollTestImplSideInvalidation::
+ base::Bind(&DISABLED_LayerTreeHostScrollTestImplSideInvalidation::
DidScrollOuterViewport,
base::Unretained(this)));
PostSetNeedsCommitToMainThread();
@@ -2098,7 +2089,7 @@ class MAYBE_LayerTreeHostScrollTestImplSideInvalidation
CompletionEvent completion;
task_runner_provider()->ImplThreadTaskRunner()->PostTask(
FROM_HERE,
- base::Bind(&MAYBE_LayerTreeHostScrollTestImplSideInvalidation::
+ base::Bind(&DISABLED_LayerTreeHostScrollTestImplSideInvalidation::
WaitForInvalidationOnImplThread,
base::Unretained(this), &completion));
completion.Wait();
@@ -2249,7 +2240,7 @@ class MAYBE_LayerTreeHostScrollTestImplSideInvalidation
int num_of_deltas_ = 0;
};
-MULTI_THREAD_TEST_F(MAYBE_LayerTreeHostScrollTestImplSideInvalidation);
+MULTI_THREAD_TEST_F(DISABLED_LayerTreeHostScrollTestImplSideInvalidation);
danakj 2017/03/03 19:53:01 optionally u can just comment out this line instea
} // namespace
} // namespace cc
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698