Remove dashed focus rect from Views checkboxes.

Remove dashed focus rect from Views checkboxes.

This makes our native checkboxes match our web checkboxes, i.e. focus
is indicated only by a blue square around the box on the left.

BUG=696003
Review-Url: https://codereview.chromium.org/2734273002
Cr-Commit-Position: refs/heads/master@{#455496}
Committed: https://chromium.googlesource.com/chromium/src/+/525950cc7033074e1a1d3e44e7de0a966345460c

[Evan Stade, 2017-03-08 00:19:14]

estade@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2017-03-08 00:26:43]

https://codereview.chromium.org/2734273002/diff/1/ui/views/controls/button/ch...
File ui/views/controls/button/checkbox.cc (left):

https://codereview.chromium.org/2734273002/diff/1/ui/views/controls/button/ch...
ui/views/controls/button/checkbox.cc:114:
SetFocusPainter(Painter::CreateDashedFocusPainterWithInsets(gfx::Insets(
The LabelButton constructor still sets a FocusPainter, and I don't think things
will call SetStyle(..) on checkbox to remove it. Should the Checkbox constructor
call SetFocusPainter(nullptr) unconditionally rather than just when UseMd() is
true?

[Evan Stade, 2017-03-08 00:38:17]

I sent this out too early it seems. I was splitting up a larger change into bite
size chunks and missed that part of it. Sorry.

https://codereview.chromium.org/2734273002/diff/1/ui/views/controls/button/ch...
File ui/views/controls/button/checkbox.cc (left):

https://codereview.chromium.org/2734273002/diff/1/ui/views/controls/button/ch...
ui/views/controls/button/checkbox.cc:114:
SetFocusPainter(Painter::CreateDashedFocusPainterWithInsets(gfx::Insets(
On 2017/03/08 00:26:43, tapted wrote:
> The LabelButton constructor still sets a FocusPainter, and I don't think
things
> will call SetStyle(..) on checkbox to remove it. Should the Checkbox
constructor
> call SetFocusPainter(nullptr) unconditionally rather than just when UseMd() is
> true?

yes!

[Evan Stade, 2017-03-08 00:38:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 00:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-03-08 00:43:00]

sweet lgtm :)

(and I'm guessing that call in the LabelButton constructor is on the chopping
block for later - looks like it's the last caller of
CreateDashedFocusPainterWithInsets, so that will be nice. Probably a bunch of
callers of SetFocusPainter(nullptr), or the method entirely, can be removed
too..)

[Evan Stade, 2017-03-08 00:44:33]

On 2017/03/08 00:43:00, tapted wrote:
> sweet lgtm :)
> 
> (and I'm guessing that call in the LabelButton constructor is on the chopping
> block for later - looks like it's the last caller of
> CreateDashedFocusPainterWithInsets, so that will be nice. Probably a bunch of
> callers of SetFocusPainter(nullptr), or the method entirely, can be removed
> too..)

yea, and DashedFocusPainter

[commit-bot: I haz the power, 2017-03-08 03:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 03:20:28]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-03-08 18:30:01]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-03-08 18:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 18:34:59]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488997801606550,
"parent_rev": "2581d91a5a2adfdae460bd25a43b44cac6f80ded", "commit_rev":
"525950cc7033074e1a1d3e44e7de0a966345460c"}

[commit-bot: I haz the power, 2017-03-08 18:35:47]

Description was changed from

==========
Remove dashed focus rect from Views checkboxes.

This makes our native checkboxes match our web checkboxes, i.e. focus
is indicated only by a blue square around the box on the left.

BUG=696003
==========

to

==========
Remove dashed focus rect from Views checkboxes.

This makes our native checkboxes match our web checkboxes, i.e. focus
is indicated only by a blue square around the box on the left.

BUG=696003

Review-Url: https://codereview.chromium.org/2734273002
Cr-Commit-Position: refs/heads/master@{#455496}
Committed:
https://chromium.googlesource.com/chromium/src/+/525950cc7033074e1a1d3e44e7de...
==========

[commit-bot: I haz the power, 2017-03-08 18:35:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/525950cc7033074e1a1d3e44e7de...