Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2734273002: Remove dashed focus rect from Views checkboxes. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
tapted
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dashed focus rect from Views checkboxes. This makes our native checkboxes match our web checkboxes, i.e. focus is indicated only by a blue square around the box on the left. BUG=696003 Review-Url: https://codereview.chromium.org/2734273002 Cr-Commit-Position: refs/heads/master@{#455496} Committed: https://chromium.googlesource.com/chromium/src/+/525950cc7033074e1a1d3e44e7de0a966345460c

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M ui/views/controls/button/checkbox.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Evan Stade
3 years, 9 months ago (2017-03-08 00:19:15 UTC) #2
tapted
https://codereview.chromium.org/2734273002/diff/1/ui/views/controls/button/checkbox.cc File ui/views/controls/button/checkbox.cc (left): https://codereview.chromium.org/2734273002/diff/1/ui/views/controls/button/checkbox.cc#oldcode114 ui/views/controls/button/checkbox.cc:114: SetFocusPainter(Painter::CreateDashedFocusPainterWithInsets(gfx::Insets( The LabelButton constructor still sets a FocusPainter, and ...
3 years, 9 months ago (2017-03-08 00:26:43 UTC) #3
Evan Stade
I sent this out too early it seems. I was splitting up a larger change ...
3 years, 9 months ago (2017-03-08 00:38:17 UTC) #4
tapted
sweet lgtm :) (and I'm guessing that call in the LabelButton constructor is on the ...
3 years, 9 months ago (2017-03-08 00:43:00 UTC) #7
Evan Stade
On 2017/03/08 00:43:00, tapted wrote: > sweet lgtm :) > > (and I'm guessing that ...
3 years, 9 months ago (2017-03-08 00:44:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734273002/20001
3 years, 9 months ago (2017-03-08 18:30:29 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 18:35:49 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/525950cc7033074e1a1d3e44e7de...

Powered by Google App Engine
This is Rietveld 408576698