Remove dashed focus rect from Views checkboxes.

ui/views/controls/button/checkbox.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/checkbox.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 86 matching lines @@
 void Checkbox::SetChecked(bool checked) {
   checked_ = checked;
   UpdateImage();
 }
 
 // static
 bool Checkbox::UseMd() {
   return ui::MaterialDesignController::IsSecondaryUiMaterial();
 }
 
-void Checkbox::Layout() {
-  LabelButton::Layout();
-
-  if (!UseMd()) {
-    // Construct a focus painter that only surrounds the label area.
-    gfx::Rect rect = label()->GetMirroredBounds();
-    rect.Inset(-2, 3);
-    SetFocusPainter(Painter::CreateDashedFocusPainterWithInsets(gfx::Insets(

[tapted, 2017/03/08 00:26:43]

The LabelButton constructor still sets a FocusPainter, and I don't think things
will call SetStyle(..) on checkbox to remove it. Should the Checkbox constructor
call SetFocusPainter(nullptr) unconditionally rather than just when UseMd() is
true?

[Evan Stade, 2017/03/08 00:38:17]

yes!

-        rect.y(), rect.x(), height() - rect.bottom(), width() - rect.right())));
-  }
-}
-
 const char* Checkbox::GetClassName() const {
   return kViewClassName;
 }
 
 void Checkbox::GetAccessibleNodeData(ui::AXNodeData* node_data) {
   LabelButton::GetAccessibleNodeData(node_data);
   node_data->role = ui::AX_ROLE_CHECK_BOX;
   if (checked())
     node_data->AddStateFlag(ui::AX_STATE_CHECKED);
   if (enabled()) {
@@ skipping 103 matching lines @@
 ui::NativeTheme::Part Checkbox::GetThemePart() const {
   return ui::NativeTheme::kCheckbox;
 }
 
 void Checkbox::GetExtraParams(ui::NativeTheme::ExtraParams* params) const {
   LabelButton::GetExtraParams(params);
   params->button.checked = checked_;
 }
 
 }  // namespace views