Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2734213003: [DevTools] Do not use Dialog.detach as it doesn't exist. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not use Dialog.detach as it doesn't exist. This is a leftover from refactoring in crrev.com/3e3774f369e1e642d06e895276b08814b279c20c. BUG=699257 Review-Url: https://codereview.chromium.org/2734213003 Cr-Commit-Position: refs/heads/master@{#455302} Committed: https://chromium.googlesource.com/chromium/src/+/0e2f711d53961feb53d460fd96073ad47ef4a366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
dgozman
Take a look please.
3 years, 9 months ago (2017-03-07 21:57:25 UTC) #2
caseq
lgtm
3 years, 9 months ago (2017-03-07 22:04:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2734213003/1
3 years, 9 months ago (2017-03-07 22:15:36 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 00:07:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e2f711d53961feb53d460fd9607...

Powered by Google App Engine
This is Rietveld 408576698