third_party/WebKit/Source/devtools/front_end/ui/Dialog.js - Issue 2734213003: [DevTools] Do not use Dialog.detach as it doesn't exist.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 2734213003: [DevTools] Do not use Dialog.detach as it doesn't exist. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

index cace1a296af311e3c4a53e4de98a49a7b21dcea4..b905558849c8ab93c35bc1a815e82890b37ebd7c 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

@@ -61,7 +61,7 @@ UI.Dialog = class extends UI.GlassPane {

var document = /** @type {!Document} */ (

where instanceof Document ? where : (where || UI.inspectorView.element).ownerDocument);

if (UI.Dialog._instance)

- UI.Dialog._instance.detach();

+ UI.Dialog._instance.hide();

UI.Dialog._instance = this;

this._disableTabIndexOnElements(document);

super.show(document);

« no previous file with comments | « no previous file | no next file » | no next file with comments »