third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl - Issue 2734173002: postMessage(): transfer allocation costs along with value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

Issue 2734173002: postMessage(): transfer allocation costs along with value. (Closed)

Patch Set: rebased upto r455878 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

index 212b495db59cbeded62532ba0ee5dc4ed810f360..33cbc14eebec1efcfb8e2649285cd02dd8cf9d44 100644

--- a/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl

@@ -465,7 +465,8 @@ static void postMessageImpl(const char* interfaceName, {{cpp_class}}* instance,

// FIXME: Only pass scriptState/exceptionState if instance really requires it.

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

- instance->postMessage(scriptState, message.release(), transferables.messagePorts, exceptionState);

+ instance->postMessage(scriptState, message.get(), transferables.messagePorts, exceptionState);

+ message->unregisterMemoryAllocatedByCurrentScriptContext();

}

{% endmacro %}