third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp - Issue 2734173002: postMessage(): transfer allocation costs along with value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 2734173002: postMessage(): transfer allocation costs along with value. (Closed)

Patch Set: rebased upto r455878 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/methods.cpp.tmpl ('k') | third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

index 87db5f03090c7bc7020a0b20236c1a6ea0f9d741..0c7632faa8357958406d1d968573dac07c91caa2 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -7700,7 +7700,8 @@ static void postMessageImpl(const char* interfaceName, TestObject* instance, con

// FIXME: Only pass scriptState/exceptionState if instance really requires it.

ScriptState* scriptState = ScriptState::current(info.GetIsolate());

- instance->postMessage(scriptState, message.release(), transferables.messagePorts, exceptionState);

+ instance->postMessage(scriptState, message.get(), transferables.messagePorts, exceptionState);

+ message->unregisterMemoryAllocatedByCurrentScriptContext();

}

static void activityLoggingForAllWorldsPerWorldBindingsVoidMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info) {